Skip to content

8309286: G1: Remove unused G1HeapRegionAttr::is_valid_gen#14260

Closed
albertnetymk wants to merge 1 commit intoopenjdk:masterfrom
albertnetymk:trivial
Closed

8309286: G1: Remove unused G1HeapRegionAttr::is_valid_gen#14260
albertnetymk wants to merge 1 commit intoopenjdk:masterfrom
albertnetymk:trivial

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jun 1, 2023

Trivial removing dead code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309286: G1: Remove unused G1HeapRegionAttr::is_valid_gen

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14260/head:pull/14260
$ git checkout pull/14260

Update a local copy of the PR:
$ git checkout pull/14260
$ git pull https://git.openjdk.org/jdk.git pull/14260/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14260

View PR using the GUI difftool:
$ git pr show -t 14260

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14260.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 1, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8309286 8309286: G1: Remove unused G1HeapRegionAttr::is_valid_gen Jun 1, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 1, 2023
@openjdk
Copy link

openjdk bot commented Jun 1, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jun 1, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 1, 2023

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it. Trivial.

@openjdk
Copy link

openjdk bot commented Jun 1, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309286: G1: Remove unused G1HeapRegionAttr::is_valid_gen

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • d987176: 8307794: Test for HSS/LMS Signature Verification
  • 050425b: 8298127: HSS/LMS Signature Verification
  • a6109bf: 8308856: jdk.internal.classfile.impl.EntryMap::nextPowerOfTwo math problem

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 1, 2023
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 2, 2023

Going to push as commit cb1e5e3.
Since your change was applied there have been 22 commits pushed to the master branch:

  • e8268d9: 8309210: Extend VM Operations hs_err logging
  • 7dbdad5: 8308892: Bad graph detected in build_loop_late after JDK-8305635
  • dc8bc6c: 8308090: Add container tests for on-the-fly resource quota updates
  • 73e7af9: 8309287: Add fontconfig requirement to building.md for Debian
  • aeb53e6: 8308711: Develop additional Tests for KEM implementation
  • dcd9590: 8309224: Fix xlc17 clang 15 warnings in java.desktop
  • 8f1ce78: 8308752: Generational ZGC: Avoid final marking through stack chunks
  • 7b0a336: 8308387: CLD created and unloading list sharing _next node pointer leads to concurrent YC missing CLD roots
  • 60f3b87: 8309295: C2: MaxNode::signed_min() returns nullptr for int operands
  • 8007599: 8309093: Underscore with brackets
  • ... and 12 more: https://git.openjdk.org/jdk/compare/6adc242cf33941f1cbaa1f9e920c8700fd59aefc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 2, 2023
@openjdk openjdk bot closed this Jun 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 2, 2023
@openjdk
Copy link

openjdk bot commented Jun 2, 2023

@albertnetymk Pushed as commit cb1e5e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the trivial branch June 2, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants