8308891: TestCDSVMCrash.java needs @requires vm.cds

[matias9927]

The recently added CDS test, TestCDSVMCrash.java, was missing the @requires vm.cds tag. This patch adds the tag as originally intended. Verified with tier1-5 tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308891: TestCDSVMCrash.java needs @requires vm.cds

Reviewers

• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14270/head:pull/14270
$ git checkout pull/14270

Update a local copy of the PR:
$ git checkout pull/14270
$ git pull https://git.openjdk.org/jdk.git pull/14270/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14270

View PR using the GUI difftool:
$ git pr show -t 14270

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14270.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@matias9927 The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (dea175c8)

[dcubed-ojdk]

Thumbs up. This is a trivial fix.

[openjdk]

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308891: TestCDSVMCrash.java needs @requires vm.cds

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 0ab0963: 8308469: [PPC64] Implement alternative fast-locking scheme
• ec55539: 8309138: Fix container tests for jdks with symlinked conf dir
• e827164: 8309146: extend JDI StackFrame.setValue() and JDWP StackFrame.setValues minimal support for virtual threads
• be36096: 8302822: Method/Field/Constructor/RecordComponent::getGenericInfo() is not thread safe
• c6f20db: 8308232: nsk/jdb tests don't pass -verbose flag to the debuggee
• d987176: 8307794: Test for HSS/LMS Signature Verification
• 050425b: 8298127: HSS/LMS Signature Verification
• a6109bf: 8308856: jdk.internal.classfile.impl.EntryMap::nextPowerOfTwo math problem
• 6adc242: 8308943: jdk.internal.le build fails on AIX
• 39f6d80: 8307990: jspawnhelper must close its writing side of a pipe before reading from it
• ... and 14 more: https://git.openjdk.org/jdk/compare/eae1f59da966f68c8e11547aec123741c1d21fef...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[matias9927]

Thanks for the review @dcubed-ojdk !
/integrate

[openjdk]

Going to push as commit 101bf22.
Since your change was applied there have been 25 commits pushed to the master branch:

• 2bb1972: 8308954: [JVMCI] code installation increments decompile_count for call_site_target_value failures
• 0ab0963: 8308469: [PPC64] Implement alternative fast-locking scheme
• ec55539: 8309138: Fix container tests for jdks with symlinked conf dir
• e827164: 8309146: extend JDI StackFrame.setValue() and JDWP StackFrame.setValues minimal support for virtual threads
• be36096: 8302822: Method/Field/Constructor/RecordComponent::getGenericInfo() is not thread safe
• c6f20db: 8308232: nsk/jdb tests don't pass -verbose flag to the debuggee
• d987176: 8307794: Test for HSS/LMS Signature Verification
• 050425b: 8298127: HSS/LMS Signature Verification
• a6109bf: 8308856: jdk.internal.classfile.impl.EntryMap::nextPowerOfTwo math problem
• 6adc242: 8308943: jdk.internal.le build fails on AIX
• ... and 15 more: https://git.openjdk.org/jdk/compare/eae1f59da966f68c8e11547aec123741c1d21fef...master

Your commit was automatically rebased without conflicts.

[openjdk]

@matias9927 Pushed as commit 101bf22.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.