8309329: com/sun/jdi/DeferredStepTest.java fails with virtual threads due to not waiting for threads to exit

[plummercj]

Virtual threads are always daemon threads, so tests that previously did not explicitly wait for test threads to exit sometimes fail with virtual threads due to the test exiting before the test threads have exited. A join() for each test thread is needed to fix this issue.

com/sun/jdi/DeferredStepTest.java is one such tests. I looked at the other com/sun/jdi failures listed in JDK-8285422 and didn't see any others that might be failing for this same reason.

I tested locally with JTREG_TEST_THREAD_FACTORY=Virtual. I'll also run the appropriate mach5 tier that tests com/sun/jdi with virtual threads.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309329: com/sun/jdi/DeferredStepTest.java fails with virtual threads due to not waiting for threads to exit

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer) ⚠️ Review applies to 24dfa505
• Leonid Mesnik (@lmesnik - Reviewer)
• Alex Menkov (@alexmenkov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14275/head:pull/14275
$ git checkout pull/14275

Update a local copy of the PR:
$ git checkout pull/14275
$ git pull https://git.openjdk.org/jdk.git pull/14275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14275

View PR using the GUI difftool:
$ git pr show -t 14275

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14275.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (f83cd766)
• 00: Full (24dfa505)

[alexmenkov]

It looks strange that there are no errors about conflict between variable names and class names.
Anyway I think it would be better to rename the variables

[sspitsyn]

This looks good modulo the comment from Alex about renaming.
Thanks,
Serguei

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309329: com/sun/jdi/DeferredStepTest.java fails with virtual threads due to not waiting for threads to exit

Reviewed-by: sspitsyn, lmesnik, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• a23bbea: 8309241: ClassForNameLeak fails intermittently as the class loader hasn't been unloaded
• 931913f: 8309200: java/net/httpclient/ExecutorShutdown fails intermittently, if connection closed during upgrade
• dc21e8a: 8296411: AArch64: Accelerated Poly1305 intrinsics
• 59d9d9f: 8303215: Make thread stacks not use huge pages
• cb1e5e3: 8309286: G1: Remove unused G1HeapRegionAttr::is_valid_gen
• e8268d9: 8309210: Extend VM Operations hs_err logging
• 7dbdad5: 8308892: Bad graph detected in build_loop_late after JDK-8305635
• dc8bc6c: 8308090: Add container tests for on-the-fly resource quota updates
• 73e7af9: 8309287: Add fontconfig requirement to building.md for Debian
• aeb53e6: 8308711: Develop additional Tests for KEM implementation
• ... and 7 more: https://git.openjdk.org/jdk/compare/101bf2290da5735fd9624ab647a8183c2c21f22d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

Thanks for the reviews Alex, Serguei, and Leonid.

/integrate

[openjdk]

Going to push as commit 1bb037b.
Since your change was applied there have been 17 commits pushed to the master branch:

• a23bbea: 8309241: ClassForNameLeak fails intermittently as the class loader hasn't been unloaded
• 931913f: 8309200: java/net/httpclient/ExecutorShutdown fails intermittently, if connection closed during upgrade
• dc21e8a: 8296411: AArch64: Accelerated Poly1305 intrinsics
• 59d9d9f: 8303215: Make thread stacks not use huge pages
• cb1e5e3: 8309286: G1: Remove unused G1HeapRegionAttr::is_valid_gen
• e8268d9: 8309210: Extend VM Operations hs_err logging
• 7dbdad5: 8308892: Bad graph detected in build_loop_late after JDK-8305635
• dc8bc6c: 8308090: Add container tests for on-the-fly resource quota updates
• 73e7af9: 8309287: Add fontconfig requirement to building.md for Debian
• aeb53e6: 8308711: Develop additional Tests for KEM implementation
• ... and 7 more: https://git.openjdk.org/jdk/compare/101bf2290da5735fd9624ab647a8183c2c21f22d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit 1bb037b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.