Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8299052 : ViewportOverlapping test fails intermittently on Win10 & Win11 #14289

Closed
wants to merge 7 commits into from

Conversation

honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented Jun 2, 2023

ViewportOverlapping test was failing intermittently during CI runs on Win10 and Win11.

Although this intermittent issue wasn't replicable when the individual test as well as the test group was run multiple times. Hence screenshot capture has been at various points in the test to aid debugging this intermittent issue, in case it should occur again.

PS: Only relevant code in OverlappingTestBase has been cleaned-up as required by this test. There are other parts of the base class that require code clean-up which is best if taken up as a separate issue as it has common code across many AWT_Mixing tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14289/head:pull/14289
$ git checkout pull/14289

Update a local copy of the PR:
$ git checkout pull/14289
$ git pull https://git.openjdk.org/jdk.git pull/14289/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14289

View PR using the GUI difftool:
$ git pr show -t 14289

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14289.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 2, 2023

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 2, 2023
@openjdk
Copy link

openjdk bot commented Jun 2, 2023

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jun 2, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 2, 2023

Webrevs

@aivanov-jdk
Copy link
Member

This is a continuation of #11747, why not in the old review?

@honkar-jdk
Copy link
Contributor Author

honkar-jdk commented Jun 2, 2023

This is a continuation of #11747, why not in the old review?

I had withdrawn the previous PR and deleted the local branch corresponding to the old changes.

@@ -401,16 +422,16 @@ protected void clickAndBlink(Robot robot, Point lLoc, boolean defaultShift) {
Util.waitForIdle(robot);
try{
Thread.sleep(500);
}catch(Exception exx){
} catch(Exception exx) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} catch(Exception exx) {
} catch (Exception exx) {

Robot robot = null;
try {
robot = new Robot();
}catch(Exception ignorex) {
} catch(Exception ignored) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} catch(Exception ignored) {
} catch (Exception ignored) {

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2014, 2018, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2014, 2022, Oracle and/or its affiliates. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2022 ?

Copy link
Contributor Author

@honkar-jdk honkar-jdk Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was by miss :)
Updated to 2023

@mrserb
Copy link
Member

mrserb commented Jun 7, 2023

DId you able to reproduce the intermittent issue in the mach5 or it is green?

@honkar-jdk
Copy link
Contributor Author

honkar-jdk commented Jun 7, 2023

DId you able to reproduce the intermittent issue in the mach5 or it is green?

I wasn't able to reproduce the intermittent issue during CI Testing - ran the test individually as well as the whole test group multiple times. Hence added screenshot captures at various points to aid debugging in case this test fails again during CI runs.

@openjdk
Copy link

openjdk bot commented Jun 12, 2023

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299052: ViewportOverlapping test fails intermittently on Win10 & Win11

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 351 new commits pushed to the master branch:

  • 45414fc: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries
  • a6ad42e: 8308645: Javadoc of FFM API needs to be refreshed
  • 0727507: 8272147: Consolidate preserved marks handling with other STW collectors
  • 6cd166a: 8309403: Serial: Remove the useless adaptive size policy in GenCollectedHeap
  • 5d5ae35: 8308966: Add intrinsic for float/double modulo for x86 AVX2 and AVX512
  • 8e4e6b0: 8309761: Leak class loader constraints
  • fdaa2c4: 8309306: G1: Move is_obj_dead from HeapRegion to G1CollectedHeap
  • 4bc6bbb: 8309814: [IR Framework] Dump socket output string in which IR encoding was not found
  • cf9e635: 8309462: [AIX] vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop
  • 268ec61: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError
  • ... and 341 more: https://git.openjdk.org/jdk/compare/939344b8433b32166f42ad73ae3d96e84b033478...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 12, 2023
@honkar-jdk
Copy link
Contributor Author

/integrate

@honkar-jdk
Copy link
Contributor Author

ViewportOverlappingTest intermittent failure was not replicable during CI testing. It has been de-problemlisted and screen capture code has been added to help debug this intermittent issue in case it should occur again.

@openjdk
Copy link

openjdk bot commented Jun 12, 2023

Going to push as commit 2dca5ae.
Since your change was applied there have been 356 commits pushed to the master branch:

  • 3028295: 8309065: Move the logic to determine archive heap location from CDS to G1 GC
  • 80a8144: 8309867: redundant class field RSAPadding.md
  • 3c15ad8: 8307144: namedParams in XECParameters and EdDSAParameters can be private final
  • 3ce1240: 8309870: Using -proc:full should be considered requesting explicit annotation processing
  • 1612b6d: 8309752: com/sun/jdi/SetLocalWhileThreadInNative.java fails with virtual test thread factory due to OpaqueFrameException
  • 45414fc: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries
  • a6ad42e: 8308645: Javadoc of FFM API needs to be refreshed
  • 0727507: 8272147: Consolidate preserved marks handling with other STW collectors
  • 6cd166a: 8309403: Serial: Remove the useless adaptive size policy in GenCollectedHeap
  • 5d5ae35: 8308966: Add intrinsic for float/double modulo for x86 AVX2 and AVX512
  • ... and 346 more: https://git.openjdk.org/jdk/compare/939344b8433b32166f42ad73ae3d96e84b033478...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 12, 2023
@openjdk openjdk bot closed this Jun 12, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jun 12, 2023
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jun 12, 2023
@openjdk
Copy link

openjdk bot commented Jun 12, 2023

@honkar-jdk Pushed as commit 2dca5ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants