Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257072: ZGC: Rename roots iterators #1429

Closed
wants to merge 3 commits into from

Conversation

pliden
Copy link
Contributor

@pliden pliden commented Nov 25, 2020

Since we no longer have any STW roots (they are all concurrent now), we can shorten the names of the roots iterators to just ZRootsIterator and ZWeakRootsIterator.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build (6/6 failed) (2/2 failed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed)

Failed test tasks

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1429/head:pull/1429
$ git checkout pull/1429

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 25, 2020

👋 Welcome back pliden! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 25, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 25, 2020

@pliden The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 25, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 25, 2020

Webrevs

@pliden pliden force-pushed the 8257072_rename_roots_iterators branch from 3dafd2b to 230f6fe Compare Nov 25, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2020

@pliden This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257072: ZGC: Rename roots iterators

Reviewed-by: ayang, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • a8e3eab: 8245026: PsAdaptiveSizePolicy::_old_gen_policy_is_ready is unused
  • b1d1499: 8256956: RegisterImpl::max_slots_per_register is incorrect on AMD64
  • 20020d1: 8254360: Re-examine use of CodeBuffer::verify_section_allocation
  • e56a8df: 8257042: [aix] Disable os.release_one_mapping_multi_commits_vm gtest
  • 9d7121c: 8256713: SwingSet2 : Slider leaves tracks in uiScale=2
  • 434b98f: 8257077: ZGC: Remove ZWorkers::run_serial()
  • f3fc0e0: 8257079: ZGC: Fold ZMark::prepare_mark() into ZMark::start()
  • a14f02d: 8256267: Relax compiler/floatingpoint/NaNTest.java for x86_32 and lower -XX:+UseSSE
  • 7c73fff: 8256486: Linux/Windows-x86 builds broken after JDK-8254231
  • 461c5fc: 8256450: Add gz option to jmap to write a gzipped heap dump
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/0d91f0a1df2dbb484e964efa4f1a9500eab799fe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 26, 2020
@pliden
Copy link
Contributor Author

@pliden pliden commented Nov 26, 2020

Thanks for reviewing!

/integrate

@openjdk openjdk bot closed this Nov 26, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2020

@pliden Since your change was applied there have been 22 commits pushed to the master branch:

  • 973255c: 8196100: javax/swing/text/JTextComponent/5074573/bug5074573.java fails
  • a8e3eab: 8245026: PsAdaptiveSizePolicy::_old_gen_policy_is_ready is unused
  • b1d1499: 8256956: RegisterImpl::max_slots_per_register is incorrect on AMD64
  • 20020d1: 8254360: Re-examine use of CodeBuffer::verify_section_allocation
  • e56a8df: 8257042: [aix] Disable os.release_one_mapping_multi_commits_vm gtest
  • 9d7121c: 8256713: SwingSet2 : Slider leaves tracks in uiScale=2
  • 434b98f: 8257077: ZGC: Remove ZWorkers::run_serial()
  • f3fc0e0: 8257079: ZGC: Fold ZMark::prepare_mark() into ZMark::start()
  • a14f02d: 8256267: Relax compiler/floatingpoint/NaNTest.java for x86_32 and lower -XX:+UseSSE
  • 7c73fff: 8256486: Linux/Windows-x86 builds broken after JDK-8254231
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/0d91f0a1df2dbb484e964efa4f1a9500eab799fe...master

Your commit was automatically rebased without conflicts.

Pushed as commit b823ad9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk-notifier bot referenced this issue Nov 26, 2020
Reviewed-by: ayang, stefank
@pliden pliden deleted the 8257072_rename_roots_iterators branch Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants