-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8309409: Update HttpInputStreamTest and BodyProcessorInputStreamTest to use hg.openjdk.org #14302
Conversation
…to use hg.openjdk.org
👋 Welcome back jpai! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing that Jaikiran. LGTM!
@jaikiran This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thank you Daniel for the quick review. Given that these are manual tests that don't get run in the CI (or github actions) and now that they are passing locally, I'll go ahead and integrate this PR. |
/integrate |
Going to push as commit ac1597b. |
Can I please get a review of this test-only change which updates these manual tests to use
https://hg.openjdk.org
instead ofhttp://hg.openjdk.java.net
?I've run these manual tests locally and they now pass with this change.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14302/head:pull/14302
$ git checkout pull/14302
Update a local copy of the PR:
$ git checkout pull/14302
$ git pull https://git.openjdk.org/jdk.git pull/14302/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14302
View PR using the GUI difftool:
$ git pr show -t 14302
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14302.diff
Webrev
Link to Webrev Comment