8309472: IGV: Add dump_igv(custom_name) for improved debugging

[chhagedorn]

When debugging, I often add multiple IR dumps throughout the code to capture different states. To do that, I'm just re-using various PHASE_XYZ CompilerPhaseType enum values:

Compile::current()->print_method(PHASE_END, 3);

But this becomes confusing when using multiple such enum values and trying to remember what they actually mean. To overcome that (and to avoid creating new enum values each time), I suggest to introduce a new dump_igv(custom_name) method where custom_name can be an arbitrary string. Then we can use the following when debugging:

Compile::current()->dump_igv("foo");
Compile::current()->dump_igv("bar");

Thanks,
Christian

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309472: IGV: Add dump_igv(custom_name) for improved debugging (Enhancement - "4")

Reviewers

• Roland Westrelin (@rwestrel - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14313/head:pull/14313
$ git checkout pull/14313

Update a local copy of the PR:
$ git checkout pull/14313
$ git pull https://git.openjdk.org/jdk.git pull/14313/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14313

View PR using the GUI difftool:
$ git pr show -t 14313

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14313.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chhagedorn The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (38002a50)

[rwestrel]

Looks good to me.

[openjdk]

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309472: IGV: Add dump_igv(custom_name) for improved debugging

Reviewed-by: roland, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 174 new commits pushed to the master branch:

• a08c5cb: 8307953: [AIX] C locale's font setting was changed by JEP 400
• 0ceb432: 8309570: ProblemList sun/security/pkcs11/Signature/TestRSAKeyLength.java
• 65bdbc7: 8309396: com/sun/jdi/JdbMethodExitTest.java fails with virtual threads due to a bug in determining the main thread id
• 4a75fd4: 8301553: Support Password-Based Cryptography in SunPKCS11
• 0a4f9ad: 8292157: Incorrect error: "block element not allowed within inline element "
• 16ab7bf: 8309505: com/sun/jdi/MethodEntryExitEvents.java due to finding wrong main thread
• d82436e: 8295071: Spec Clarification : ClassFileFormatVersion: System property java.class.version | Java class format version number
• 571fbdc: 8309506: com/sun/jdi/MultiBreakpointsTest.java fails with virtual test thread factory
• 7d1147e: 8309554: Update descriptions in SourceVersion
• 9526190: 8307840: SequencedMap view method specification and implementation adjustments
• ... and 164 more: https://git.openjdk.org/jdk/compare/90e57fd5a96199b01e7c058a4d8a82e467d7f41a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[chhagedorn]

Thanks Roland for your review!

[TobiHartmann]

Looks good.

[chhagedorn]

Thanks Tobias for your review!

/integrate

[openjdk]

Going to push as commit 0ed4af7.
Since your change was applied there have been 175 commits pushed to the master branch:

• f1c7afc: 8306647: Implementation of Structured Concurrency (Preview)
• a08c5cb: 8307953: [AIX] C locale's font setting was changed by JEP 400
• 0ceb432: 8309570: ProblemList sun/security/pkcs11/Signature/TestRSAKeyLength.java
• 65bdbc7: 8309396: com/sun/jdi/JdbMethodExitTest.java fails with virtual threads due to a bug in determining the main thread id
• 4a75fd4: 8301553: Support Password-Based Cryptography in SunPKCS11
• 0a4f9ad: 8292157: Incorrect error: "block element not allowed within inline element "
• 16ab7bf: 8309505: com/sun/jdi/MethodEntryExitEvents.java due to finding wrong main thread
• d82436e: 8295071: Spec Clarification : ClassFileFormatVersion: System property java.class.version | Java class format version number
• 571fbdc: 8309506: com/sun/jdi/MultiBreakpointsTest.java fails with virtual test thread factory
• 7d1147e: 8309554: Update descriptions in SourceVersion
• ... and 165 more: https://git.openjdk.org/jdk/compare/90e57fd5a96199b01e7c058a4d8a82e467d7f41a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@chhagedorn Pushed as commit 0ed4af7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.