8309498: [JVMCI] race in CallSiteTargetValue recording

[tkrodriguez]

intermittent failures with Graal on ContinuousCallSiteTargetChange showed that when constructing the CallSiteTargetValue Assumption we read the value twice so the dependency and the value in the program might be different leading to incorrect execution.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309498: [JVMCI] race in CallSiteTargetValue recording (Bug - "3")

Reviewers

• Doug Simon (@dougxc - Committer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14315/head:pull/14315
$ git checkout pull/14315

Update a local copy of the PR:
$ git checkout pull/14315
$ git pull https://git.openjdk.org/jdk.git pull/14315/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14315

View PR using the GUI difftool:
$ git pr show -t 14315

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14315.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back never! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tkrodriguez The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7338884c)

[vnkozlov]

Looks good.

[openjdk]

@tkrodriguez This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309498: [JVMCI] race in CallSiteTargetValue recording

Reviewed-by: dnsimon, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

• 33bb64f: 8309614: [BACKOUT] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING
• 5b147eb: 8308288: Fix xlc17 clang warnings and build errors in hotspot
• 89f5bac: 8309225: Fix xlc17 clang 15 warnings in security and servicability
• 6eddbe2: 8309219: Fix xlc17 clang 15 warnings in java.base
• 177e832: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING
• f0236ed: 8309543: Micro-optimize x86 assembler UseCondCardMark
• 9d7bf53: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots
• a1ab377: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE
• c49129f: 8308445: Linker should check that capture state segment is big enough
• fa79111: 8308031: Linkers should reject unpromoted variadic parameters
• ... and 54 more: https://git.openjdk.org/jdk/compare/3fa776d66a8eb117410025bca870b2e7f3f00517...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tkrodriguez]

/integrate

[openjdk]

Going to push as commit bb96682.
Since your change was applied there have been 85 commits pushed to the master branch:

• 5a706fb: 8306584: Start of release updates for JDK 22
• bb377b2: 8306841: Generational ZGC: NMT reports Java heap size larger than max heap size
• ac3ce2b: 8304425: ClassHierarchyResolver from Reflection
• 79a4ac7: 8309235: Unnamed Variables (_) can't be used in JShell
• 9d64a9d: 8306431: File.listRoots method description should be re-examined
• 5af9d2a: 8309602: update JVMTI history table for jdk 21
• 6646272: 8308764: Reporting errors from create_vm may crash
• 73dd03c: 8308152: PropertyDescriptor should work with overridden generic getter method
• 760cb04: 8309569: sun/security/pkcs11/Signature/TestRSAKeyLength.java fails after JDK-8301553
• e8a5984: 8309630: Clean up tests that reference deploy modules
• ... and 75 more: https://git.openjdk.org/jdk/compare/3fa776d66a8eb117410025bca870b2e7f3f00517...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tkrodriguez Pushed as commit bb96682.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.