8301721: lookup.findSpecial fails on Object method call from interface

[mlchung]

Lookup.findSpecial fails on Object method call from an interface because of a bug in the implementation calling Class::getSuperclass on an interface which has no superclass. The implementation should only search the method from its superclass only if it's a class. This patch is trivial and skip the superclass search if it's an interface.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301721: lookup.findSpecial fails on Object method call from interface

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14319/head:pull/14319
$ git checkout pull/14319

Update a local copy of the PR:
$ git checkout pull/14319
$ git pull https://git.openjdk.org/jdk.git pull/14319/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14319

View PR using the GUI difftool:
$ git pr show -t 14319

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14319.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mlchung The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (39bfecc9)

[AlanBateman]

This looks right, there's no superclass to search.

[openjdk]

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301721: lookup.findSpecial fails on Object method call from interface

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• ca6f07f: 8309534: @jep(number=430, title="String Templates") should use default status
• 8f0839b: 8308748: JNU_GetStringPlatformChars may write to String's internal memory array
• 01455a0: 8304878: ConcurrentModificationException in javadoc tool
• 7d25bf7: 8309419: RISC-V: Relax register constraint for AddReductionVF & AddReductionVD nodes
• 5146a58: 8309418: RISC-V: Make use of vl1r.v & vfabs.v pseudo-instructions where appropriate
• 41bf2ad: 8308875: java/awt/Toolkit/GetScreenInsetsCustomGC/GetScreenInsetsCustomGC.java failed with 'Cannot invoke "sun.awt.X11GraphicsDevice.getInsets()" because "device" is null'
• a7a0913: 8309346: Extend hs_err logging for all VM operations deriving from VM_GC_Operation
• 3b85f84: 8309340: Provide sctpHandleSocketErrorWithMessage
• 2e9eff5: 8309406: Change jdk.trackAllThreads to default to true
• 6d155a4: 8308167: SequencedMap::firstEntry throws NPE when first entry has null key or value
• ... and 2 more: https://git.openjdk.org/jdk/compare/98b53c06cfffe7b2e21968546b4aa1523f31132e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlchung]

/integrate

[openjdk]

Going to push as commit 74dc50b.
Since your change was applied there have been 17 commits pushed to the master branch:

• 0f0fda7: 8309542: compiler/jvmci/TestEnableJVMCIProduct.java fails with "JVMCI compiler 'graal' specified by jvmci.Compiler not found"
• 38cef2a: 8309413: Improve the performance of MethodTypeDesc::descriptorString
• 7edd054: 8309501: Remove workaround in bin/idea.sh for non standard JVMCI file layout
• 9188142: 8309216: Cast from jchar* to char* in test java/io/GetXSpace.java
• d709c25: 8307887: (fs) Files.createSymbolicLink throws less specific exception when in developer mode and file already exists
• ca6f07f: 8309534: @jep(number=430, title="String Templates") should use default status
• 8f0839b: 8308748: JNU_GetStringPlatformChars may write to String's internal memory array
• 01455a0: 8304878: ConcurrentModificationException in javadoc tool
• 7d25bf7: 8309419: RISC-V: Relax register constraint for AddReductionVF & AddReductionVD nodes
• 5146a58: 8309418: RISC-V: Make use of vl1r.v & vfabs.v pseudo-instructions where appropriate
• ... and 7 more: https://git.openjdk.org/jdk/compare/98b53c06cfffe7b2e21968546b4aa1523f31132e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mlchung Pushed as commit 74dc50b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.