Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257077: ZGC: Remove ZWorkers::run_serial() #1432

Closed
wants to merge 1 commit into from

Conversation

pliden
Copy link
Contributor

@pliden pliden commented Nov 25, 2020

ZWorkers::run_serial() is no longer used and can be removed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build (6/6 failed) (2/2 failed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed)

Failed test tasks

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1432/head:pull/1432
$ git checkout pull/1432

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 25, 2020

👋 Welcome back pliden! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 25, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 25, 2020

@pliden The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 25, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 25, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Nov 25, 2020

@pliden This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257077: ZGC: Remove ZWorkers::run_serial()

Reviewed-by: stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 461c5fc: 8256450: Add gz option to jmap to write a gzipped heap dump
  • dee79d6: 8253936: Replace ... with {@code ...} for java.sql
  • cfb175d: 8256508: Improve CompileCommand flag
  • 7aed9b6: 8256016: Dacapo24H.java failed with "assert(false) failed: unscheduable graph"
  • 26e6cb3: 8256489: Make gtest for long path names on Windows more resilient in the presence of virus scanners
  • 911f16d: 8257056: Submit workflow should apt-get update to avoid package installation errors
  • b0bd0c2: 8256755: Update build.tools.depend.Depend to handle record components in API signatures
  • 9aeadbb: 8256865: Foreign Memory Access and Linker API are missing NPE checks
  • 8cd2e0f: 8243315: ParallelScavengeHeap::initialize() passes GenAlignment as page size to os::trace_page_sizes instead of actual page size
  • cdb41ba: 8255904: Remove superfluous use of reflection in Class::isRecord
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/0d91f0a1df2dbb484e964efa4f1a9500eab799fe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 25, 2020
@pliden
Copy link
Contributor Author

@pliden pliden commented Nov 25, 2020

Thanks for reviewing!

/integrate

@openjdk openjdk bot closed this Nov 25, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 25, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 25, 2020

@pliden Since your change was applied there have been 15 commits pushed to the master branch:

  • f3fc0e0: 8257079: ZGC: Fold ZMark::prepare_mark() into ZMark::start()
  • a14f02d: 8256267: Relax compiler/floatingpoint/NaNTest.java for x86_32 and lower -XX:+UseSSE
  • 7c73fff: 8256486: Linux/Windows-x86 builds broken after JDK-8254231
  • 461c5fc: 8256450: Add gz option to jmap to write a gzipped heap dump
  • dee79d6: 8253936: Replace ... with {@code ...} for java.sql
  • cfb175d: 8256508: Improve CompileCommand flag
  • 7aed9b6: 8256016: Dacapo24H.java failed with "assert(false) failed: unscheduable graph"
  • 26e6cb3: 8256489: Make gtest for long path names on Windows more resilient in the presence of virus scanners
  • 911f16d: 8257056: Submit workflow should apt-get update to avoid package installation errors
  • b0bd0c2: 8256755: Update build.tools.depend.Depend to handle record components in API signatures
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/0d91f0a1df2dbb484e964efa4f1a9500eab799fe...master

Your commit was automatically rebased without conflicts.

Pushed as commit 434b98f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pliden pliden deleted the 8257077_remove_run_serial branch Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
2 participants