JDK-8309503: Improve javax.lang.model tests for JEP 445

[jddarcy]

Improve testing methodology for unnamed classes in javax.lang.model, including coverage of binary names.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309503: Improve javax.lang.model tests for JEP 445 (Enhancement - P4)

Reviewers

• Jan Lahoda (@lahodaj - Reviewer) ⚠️ Review applies to 5fd8a047
• Jonathan Gibbons (@jonathan-gibbons - Reviewer)
• Jim Laskey (@JimLaskey - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14321/head:pull/14321
$ git checkout pull/14321

Update a local copy of the PR:
$ git checkout pull/14321
$ git pull https://git.openjdk.org/jdk.git pull/14321/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14321

View PR using the GUI difftool:
$ git pr show -t 14321

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14321.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jddarcy The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full (6410c525)
• 04: Full - Incremental (248832b5)
• 03: Full - Incremental (e1b5328a)
• 02: Full - Incremental (7c629490)
• 01: Full - Incremental (5fd8a047)
• 00: Full (b142bb8b)

[lahodaj]

Looks OK to me.

[openjdk]

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309503: Improve javax.lang.model tests for JEP 445

Reviewed-by: jlahoda, jjg, jlaskey

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jddarcy]

Note using the enablePreview jtreg in the test rather than the explicit option to the compile commands didn't work; I didn't try to investigate in detail.

Note I'll revert the changes in ClassReader.java before pushing; they were borrowed from #14344 to get the test working with a corrected javac.

[JimLaskey]

LGTM - ran test

[jddarcy]

/integrate

[openjdk]

Going to push as commit c24b0ba.
Since your change was applied there has been 1 commit pushed to the master branch:

• a54f4d4: 8309509: com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java fails with virtual test thread factory

Your commit was automatically rebased without conflicts.

[openjdk]

@jddarcy Pushed as commit c24b0ba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.