8309509: com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java fails with virtual test thread factory

[plummercj]

The test fails with the virtual test thread factory because it tries to find the "main" thread in the list of threads returned by JDI, but "main" is a virtual thread and will only be returned by JDI if the debug agent is launched with includevirtualthreads=y. As a result the thread is not found and the test asserts:

java.lang.RuntimeException: assertTrue: expected true, was false
at jdk.test.lib.Asserts.fail(Asserts.java:594)
at jdk.test.lib.Asserts.assertTrue(Asserts.java:486)
at jdk.test.lib.Asserts.assertTrue(Asserts.java:472)
at TestNestmateAttr.checkGoodTransforms(TestNestmateAttr.java:511)
at TestNestmateAttr.methodEntered(TestNestmateAttr.java:320)
at TestScaffold$EventHandler.notifyEvent(TestScaffold.java:205)
at TestScaffold$EventHandler.run(TestScaffold.java:279)
at java.base/java.lang.Thread.run(Thread.java:1583)

The fix is to always run the debug agent with includevirtualthreads=y.

Tested by running all com/sun/jdi tests locally with and without the virtual test thread factory. Also ran tier1 and tier5 svc test tasks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309509: com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java fails with virtual test thread factory (Bug - "4")

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Alex Menkov (@alexmenkov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14324/head:pull/14324
$ git checkout pull/14324

Update a local copy of the PR:
$ git checkout pull/14324
$ git pull https://git.openjdk.org/jdk.git pull/14324/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14324

View PR using the GUI difftool:
$ git pr show -t 14324

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14324.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0f3ce56b)

[sspitsyn]

Looks good.
Thanks,
Serguei

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309509: com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java fails with virtual test thread factory

Reviewed-by: sspitsyn, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

• a08c5cb: 8307953: [AIX] C locale's font setting was changed by JEP 400
• 0ceb432: 8309570: ProblemList sun/security/pkcs11/Signature/TestRSAKeyLength.java
• 65bdbc7: 8309396: com/sun/jdi/JdbMethodExitTest.java fails with virtual threads due to a bug in determining the main thread id
• 4a75fd4: 8301553: Support Password-Based Cryptography in SunPKCS11
• 0a4f9ad: 8292157: Incorrect error: "block element not allowed within inline element "
• 16ab7bf: 8309505: com/sun/jdi/MethodEntryExitEvents.java due to finding wrong main thread
• d82436e: 8295071: Spec Clarification : ClassFileFormatVersion: System property java.class.version | Java class format version number
• 571fbdc: 8309506: com/sun/jdi/MultiBreakpointsTest.java fails with virtual test thread factory
• 7d1147e: 8309554: Update descriptions in SourceVersion
• 9526190: 8307840: SequencedMap view method specification and implementation adjustments
• ... and 37 more: https://git.openjdk.org/jdk/compare/ecb17532dc8f3e271ad2d6550127a2253569cf9b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

Thanks for the reviews Alex and Serguei!

/integrate

[openjdk]

Going to push as commit a54f4d4.
Since your change was applied there have been 69 commits pushed to the master branch:

• 33bb64f: 8309614: [BACKOUT] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING
• 5b147eb: 8308288: Fix xlc17 clang warnings and build errors in hotspot
• 89f5bac: 8309225: Fix xlc17 clang 15 warnings in security and servicability
• 6eddbe2: 8309219: Fix xlc17 clang 15 warnings in java.base
• 177e832: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING
• f0236ed: 8309543: Micro-optimize x86 assembler UseCondCardMark
• 9d7bf53: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots
• a1ab377: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE
• c49129f: 8308445: Linker should check that capture state segment is big enough
• fa79111: 8308031: Linkers should reject unpromoted variadic parameters
• ... and 59 more: https://git.openjdk.org/jdk/compare/ecb17532dc8f3e271ad2d6550127a2253569cf9b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit a54f4d4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.