Skip to content

8309511: Regression test ExtraImportSemicolon.java refers to the wrong bug#14327

Closed
archiecobbs wants to merge 1 commit intoopenjdk:masterfrom
archiecobbs:JDK-8309511
Closed

8309511: Regression test ExtraImportSemicolon.java refers to the wrong bug#14327
archiecobbs wants to merge 1 commit intoopenjdk:masterfrom
archiecobbs:JDK-8309511

Conversation

@archiecobbs
Copy link
Contributor

@archiecobbs archiecobbs commented Jun 6, 2023

Please review this trivial fix for an incorrect @bug reference in ExtraImportSemicolon.java.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309511: Regression test ExtraImportSemicolon.java refers to the wrong bug (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14327/head:pull/14327
$ git checkout pull/14327

Update a local copy of the PR:
$ git checkout pull/14327
$ git pull https://git.openjdk.org/jdk.git pull/14327/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14327

View PR using the GUI difftool:
$ git pr show -t 14327

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14327.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 6, 2023

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 6, 2023
@openjdk
Copy link

openjdk bot commented Jun 6, 2023

@archiecobbs The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Jun 6, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 6, 2023

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@openjdk
Copy link

openjdk bot commented Jun 7, 2023

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309511: Regression test ExtraImportSemicolon.java refers to the wrong bug

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 165 new commits pushed to the master branch:

  • 3e0bbd2: 8285368: Overhaul doc-comment inheritance
  • 3eeb681: 8167252: Some of Charset.availableCharsets() does not contain itself
  • 653a8d0: 8310129: SetupNativeCompilation LIBS should match the order of the other parameters
  • 947f149: 8308444: LoadStoreNode::result_not_used() is too conservative
  • 8b4af46: 8309974: some JVMCI tests fail when VM options include -XX:+EnableJVMCI
  • 0038491: 8309978: [x64] Fix useless padding
  • 5f3613e: 8309960: ParallelGC young collections very slow in DelayInducer
  • 83d9267: 8303513: C2: LoadKlassNode::make fails with 'expecting TypeKlassPtr'
  • de8aca2: 8307907: [ppc] Remove RTM locking implementation
  • 4c0e164: 8309717: C2: Remove Arena::move_contents usage
  • ... and 155 more: https://git.openjdk.org/jdk/compare/6d155a47f13ff80cf7a9de363fc5ae2943b6603a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 7, 2023
@archiecobbs
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 7, 2023
@openjdk
Copy link

openjdk bot commented Jun 7, 2023

@archiecobbs
Your change (at version 29e1a19) is now ready to be sponsored by a Committer.

@vicente-romero-oracle
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

Going to push as commit bcc4d36.
Since your change was applied there have been 191 commits pushed to the master branch:

  • 71baf00: 8309605: StubRoutines are not used by SA
  • 16134f4: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing
  • d6c2ee3: 8310054: ScrollPane insets are incorrect
  • 4eb4f20: 8308808: SunMSCAPI public keys returns internal key array
  • 53abba3: 8309499: javac fails to report compiler.err.no.java.lang with annotation processing enabled
  • cf8d0b0: 8309964: Use directed inheritDoc for javax.lang.model API
  • a45f929: 8310076: Reduce inclusion of bytecodeStream.hpp
  • 21f6d83: 8309471: Limit key characters in static index pages
  • 44a8aa0: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations"
  • b412fc7: 8309937: Add @sealedGraph for some Panama FFM interfaces
  • ... and 181 more: https://git.openjdk.org/jdk/compare/6d155a47f13ff80cf7a9de363fc5ae2943b6603a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 16, 2023
@openjdk openjdk bot closed this Jun 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@vicente-romero-oracle @archiecobbs Pushed as commit bcc4d36.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants