Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8304403: Remove unused methods in RangeCheckElimination::Bound #14328

Closed
wants to merge 1 commit into from

Conversation

enothum
Copy link
Contributor

@enothum enothum commented Jun 6, 2023

Removed 3 unused methods in RangeCheckElimination:

RangeCheckEliminator::Bound::set_lower
RangeCheckEliminator::Bound::set_upper
RangeCheckEliminator::Bound::add_constant

Testing passed after removal


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8304403: Remove unused methods in RangeCheckElimination::Bound (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14328/head:pull/14328
$ git checkout pull/14328

Update a local copy of the PR:
$ git checkout pull/14328
$ git pull https://git.openjdk.org/jdk.git pull/14328/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14328

View PR using the GUI difftool:
$ git pr show -t 14328

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14328.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 6, 2023

👋 Welcome back enothum! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 6, 2023

@enothum The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 6, 2023
@enothum enothum marked this pull request as ready for review June 12, 2023 07:12
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 12, 2023

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk
Copy link

openjdk bot commented Jun 12, 2023

@enothum This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304403: Remove unused methods in RangeCheckElimination::Bound

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 109 new commits pushed to the master branch:

  • 6c3e621: 8308749: C2 failed: regular loops only (counted loop inside infinite loop)
  • f5cbe53: 8027711: Unify wildcarding syntax for CompileCommand and CompileOnly
  • 4d66d97: 8309549: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java fails on AIX
  • 3981297: 8309703: AIX build fails after JDK-8280982
  • 16c3d53: 8308603: Removing do_pending_ref/enclosing_ref from MetaspaceClosure
  • b94b679: 8309627: Incorrect sorting of DirtyCardQueue buffers
  • aace3dc: 8309760: ProblemList serviceability/jvmti/vthread/FollowReferences/VThreadStackRefTest.java#default with ZGC
  • 80edd5c: 8294985: SSLEngine throws IAE during parsing of X500Principal
  • bdd81b3: 8304885: Reuse stale data to improve DNS resolver resiliency
  • beec734: 8309692: Fix -Wconversion warnings in javaClasses
  • ... and 99 more: https://git.openjdk.org/jdk/compare/6d511f1376e3a0183a484443d05142678bdaa1c2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 12, 2023
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@enothum
Copy link
Contributor Author

enothum commented Jun 12, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 12, 2023
@openjdk
Copy link

openjdk bot commented Jun 12, 2023

@enothum
Your change (at version 1578ca7) is now ready to be sponsored by a Committer.

@TobiHartmann
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 13, 2023

Going to push as commit 6d05360.
Since your change was applied there have been 136 commits pushed to the master branch:

  • 9b0baa1: 8306281: function isWsl() returns false on WSL2
  • c884862: 8309468: Remove jvmti Allocate locker test case
  • 05f896a: 8309862: Unsafe list operations in JfrStringPool
  • 4f23fc1: 8309671: Avoid using jvmci.Compiler property to determine if Graal is enabled
  • 1a9edb8: 8309838: Classfile API Util.toBinaryName and other cleanup
  • f7de726: 8295555: Primitive wrapper caches could be @Stable
  • 5d71612: 8309852: G1: Remove unnecessary assert_empty in G1ParScanThreadStateSet destructor
  • 23a54f3: 8309538: G1: Move total collection increment from Cleanup to Remark
  • 57fc9a3: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader
  • 2dca5ae: 8299052: ViewportOverlapping test fails intermittently on Win10 & Win11
  • ... and 126 more: https://git.openjdk.org/jdk/compare/6d511f1376e3a0183a484443d05142678bdaa1c2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 13, 2023
@openjdk openjdk bot closed this Jun 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 13, 2023
@openjdk
Copy link

openjdk bot commented Jun 13, 2023

@TobiHartmann @enothum Pushed as commit 6d05360.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants