JDK-8309568 javac crashes attempting to -Xprint on a class file of an unnamed class

[JimLaskey]

Test development for JDK-8309503 found that javac crashed attempting to -Xprint on a class file of an unnamed class. The test for ClassReader detecting of unnamed class was forcing completion of the owner class. The new code uses a flags only test.

Related test is with https://bugs.openjdk.org/browse/JDK-8309503 .

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309568: javac crashes attempting to -Xprint on a class file of an unnamed class (Bug - "2")

Reviewers

• Joe Darcy (@jddarcy - Reviewer)
• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14344/head:pull/14344
$ git checkout pull/14344

Update a local copy of the PR:
$ git checkout pull/14344
$ git pull https://git.openjdk.org/jdk.git pull/14344/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14344

View PR using the GUI difftool:
$ git pr show -t 14344

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14344.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JimLaskey The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (08c0dd40)

[jddarcy]

I confirm that the tests now in #14321 pass when run with the changes in this PR.

[jddarcy]

Approving in the sense of affirming the related test passes; one or more javac engineers should review the change too.

[openjdk]

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309568: javac crashes attempting to -Xprint on a class file of an unnamed class

Reviewed-by: darcy, jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 749d480: 8305763: Parsing a URI with an underscore goes through a silent exception, negatively impacting performance
• 3ccb3c0: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address
• a25b7b8: 8295976: GetThreadListStackTraces returns wrong state for blocked VirtualThread
• fadcd65: 8309527: Improve test proxy performance
• 0ed4af7: 8309472: IGV: Add dump_igv(custom_name) for improved debugging
• f1c7afc: 8306647: Implementation of Structured Concurrency (Preview)
• a08c5cb: 8307953: [AIX] C locale's font setting was changed by JEP 400
• 0ceb432: 8309570: ProblemList sun/security/pkcs11/Signature/TestRSAKeyLength.java
• 65bdbc7: 8309396: com/sun/jdi/JdbMethodExitTest.java fails with virtual threads due to a bug in determining the main thread id

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

Looks reasonable.

[JimLaskey]

/integrate

[openjdk]

Going to push as commit a6726b6.
Since your change was applied there have been 11 commits pushed to the master branch:

• 8cdd95e: 8305959: x86: Improve itable_stub
• 9233dcc: 8309297: Adjust ShenandoahHeap print_heap_regions_on
• 749d480: 8305763: Parsing a URI with an underscore goes through a silent exception, negatively impacting performance
• 3ccb3c0: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address
• a25b7b8: 8295976: GetThreadListStackTraces returns wrong state for blocked VirtualThread
• fadcd65: 8309527: Improve test proxy performance
• 0ed4af7: 8309472: IGV: Add dump_igv(custom_name) for improved debugging
• f1c7afc: 8306647: Implementation of Structured Concurrency (Preview)
• a08c5cb: 8307953: [AIX] C locale's font setting was changed by JEP 400
• 0ceb432: 8309570: ProblemList sun/security/pkcs11/Signature/TestRSAKeyLength.java
• ... and 1 more: https://git.openjdk.org/jdk/compare/4a75fd462c002a209201d8bfc8d6c9eb286a7444...master

Your commit was automatically rebased without conflicts.

[openjdk]

@JimLaskey Pushed as commit a6726b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.