Skip to content

8309562: [JVMCI] Export symbols used by VirtualThread notifyJvmti intrinsics to JVMCI compilers. #14348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

8309562: [JVMCI] Export symbols used by VirtualThread notifyJvmti intrinsics to JVMCI compilers. #14348

wants to merge 2 commits into from

Conversation

@mur47x111
Copy link
Contributor

@mur47x111 mur47x111 commented Jun 7, 2023 •
edited by openjdk bot
Loading

This PR allows JVMCI compiler to implement VirtualThread notifyJvmti intrinsics.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309562: [JVMCI] Export symbols used by VirtualThread notifyJvmti intrinsics to JVMCI compilers. (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14348/head:pull/14348
$ git checkout pull/14348

Update a local copy of the PR:
$ git checkout pull/14348
$ git pull https://git.openjdk.org/jdk.git pull/14348/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14348

View PR using the GUI difftool:
$ git pr show -t 14348

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14348.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2023

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 7, 2023
@openjdk
Copy link

openjdk bot commented Jun 7, 2023

@mur47x111 The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Jun 7, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2023 •
edited
Loading

Webrevs

vnkozlov
vnkozlov reviewed Jun 7, 2023
View reviewed changes
src/hotspot/share/jvmci/vmStructs_jvmci.cpp Outdated
JVMTI_ONLY(nonstatic_field(JavaThread, _is_in_VTMS_transition, bool)) \
JVMTI_ONLY(nonstatic_field(JavaThread, _is_in_tmp_VTMS_transition, bool)) \
\
static_field(JvmtiVTMSTransitionDisabler, _VTMS_notify_jvmti_events, bool) \
Copy link
Contributor

@vnkozlov vnkozlov Jun 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be also under JVMTI_ONLY(). Did you have issues if you do that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Thought it was accessible without JVMTI. Thanks for pointing this out, I have pushed an update.

vnkozlov
vnkozlov approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk
Copy link

openjdk bot commented Jun 7, 2023 •
edited
Loading

@mur47x111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309562: [JVMCI] Export symbols used by VirtualThread notifyJvmti intrinsics to JVMCI compilers.

Reviewed-by: dnsimon, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

  • 92beb85: 8309474: [IR Framework] Wrong @ForceCompile link in README
  • 6402004: 8256302: releasing oopStorage when deflating allows for faster deleting
  • 02bce0b: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI
  • 4ffc8cc: 8309574: Improve core reflection tests for JEP 445
  • e3f3ac0: 8309420: com/sun/jdi/StepTest.java fails with virtual thread wrapper
  • c38abbf: 8309510: com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java no longer needs to override startUp() method
  • c24b0ba: 8309503: Improve javax.lang.model tests for JEP 445
  • a54f4d4: 8309509: com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java fails with virtual test thread factory
  • 33bb64f: 8309614: [BACKOUT] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING
  • 5b147eb: 8308288: Fix xlc17 clang warnings and build errors in hotspot
  • ... and 55 more: https://git.openjdk.org/jdk/compare/6d511f1376e3a0183a484443d05142678bdaa1c2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dougxc, @vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 7, 2023
@mur47x111
Copy link
Contributor Author

/integrate

@dougxc
Copy link
Member

dougxc commented Jun 7, 2023

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 7, 2023
@openjdk
Copy link

openjdk bot commented Jun 7, 2023

@mur47x111
Your change (at version cd5222b) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Jun 7, 2023

Going to push as commit 99749c5.
Since your change was applied there have been 65 commits pushed to the master branch:

  • 92beb85: 8309474: [IR Framework] Wrong @ForceCompile link in README
  • 6402004: 8256302: releasing oopStorage when deflating allows for faster deleting
  • 02bce0b: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI
  • 4ffc8cc: 8309574: Improve core reflection tests for JEP 445
  • e3f3ac0: 8309420: com/sun/jdi/StepTest.java fails with virtual thread wrapper
  • c38abbf: 8309510: com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java no longer needs to override startUp() method
  • c24b0ba: 8309503: Improve javax.lang.model tests for JEP 445
  • a54f4d4: 8309509: com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java fails with virtual test thread factory
  • 33bb64f: 8309614: [BACKOUT] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING
  • 5b147eb: 8308288: Fix xlc17 clang warnings and build errors in hotspot
  • ... and 55 more: https://git.openjdk.org/jdk/compare/6d511f1376e3a0183a484443d05142678bdaa1c2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 7, 2023
@openjdk openjdk bot closed this Jun 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 7, 2023
@openjdk
Copy link

openjdk bot commented Jun 7, 2023

@dougxc @mur47x111 Pushed as commit 99749c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dougxc dougxc dougxc approved these changes

@vnkozlov vnkozlov vnkozlov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mur47x111 @dougxc @vnkozlov