Skip to content

8309602: update JVMTI history table for jdk 21 #14352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

sspitsyn
Copy link
Contributor

@sspitsyn sspitsyn commented Jun 7, 2023

This is a minor update of the jvmti.xml file.
The JVM TI history table needs to be updated to list:

  • Virtual threads finalized to be a permanent feature.
  • Agent start-up in the live phase now specified to print a warning.

The JVM TI history table has no normative changes. This update does not need a CSR.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309602: update JVMTI history table for jdk 21 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14352/head:pull/14352
$ git checkout pull/14352

Update a local copy of the PR:
$ git checkout pull/14352
$ git pull https://git.openjdk.org/jdk.git pull/14352/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14352

View PR using the GUI difftool:
$ git pr show -t 14352

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14352.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2023

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 7, 2023
@openjdk
Copy link

openjdk bot commented Jun 7, 2023

@sspitsyn The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Jun 7, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2023

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion for the 19.0.0 note, otherwise good.

@openjdk
Copy link

openjdk bot commented Jun 7, 2023

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309602: update JVMTI history table for jdk 21

Reviewed-by: alanb, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • 6646272: 8308764: Reporting errors from create_vm may crash
  • 73dd03c: 8308152: PropertyDescriptor should work with overridden generic getter method
  • 760cb04: 8309569: sun/security/pkcs11/Signature/TestRSAKeyLength.java fails after JDK-8301553
  • e8a5984: 8309630: Clean up tests that reference deploy modules
  • 90027ff: 8309515: Stale cached data from Matcher.namedGroups() after Matcher.usePattern()
  • ea41907: 8297923: java.awt.ScrollPane broken after multiple scroll up/down
  • 99749c5: 8309562: [JVMCI] Export symbols used by VirtualThread notifyJvmti intrinsics to JVMCI compilers.
  • 92beb85: 8309474: [IR Framework] Wrong @ForceCompile link in README
  • 6402004: 8256302: releasing oopStorage when deflating allows for faster deleting
  • 02bce0b: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI
  • ... and 20 more: https://git.openjdk.org/jdk/compare/9233dcc8380c6e7cd7bbf7a1f4c0a6873429ea53...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 7, 2023
Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sspitsyn
Copy link
Contributor Author

sspitsyn commented Jun 8, 2023

Alan and Iris, thank you for review!

@sspitsyn
Copy link
Contributor Author

sspitsyn commented Jun 8, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 8, 2023

Going to push as commit 5af9d2a.
Since your change was applied there have been 30 commits pushed to the master branch:

  • 6646272: 8308764: Reporting errors from create_vm may crash
  • 73dd03c: 8308152: PropertyDescriptor should work with overridden generic getter method
  • 760cb04: 8309569: sun/security/pkcs11/Signature/TestRSAKeyLength.java fails after JDK-8301553
  • e8a5984: 8309630: Clean up tests that reference deploy modules
  • 90027ff: 8309515: Stale cached data from Matcher.namedGroups() after Matcher.usePattern()
  • ea41907: 8297923: java.awt.ScrollPane broken after multiple scroll up/down
  • 99749c5: 8309562: [JVMCI] Export symbols used by VirtualThread notifyJvmti intrinsics to JVMCI compilers.
  • 92beb85: 8309474: [IR Framework] Wrong @ForceCompile link in README
  • 6402004: 8256302: releasing oopStorage when deflating allows for faster deleting
  • 02bce0b: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI
  • ... and 20 more: https://git.openjdk.org/jdk/compare/9233dcc8380c6e7cd7bbf7a1f4c0a6873429ea53...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 8, 2023
@openjdk openjdk bot closed this Jun 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 8, 2023
@openjdk
Copy link

openjdk bot commented Jun 8, 2023

@sspitsyn Pushed as commit 5af9d2a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sspitsyn sspitsyn deleted the br41 branch June 8, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants