Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309627: Incorrect sorting of DirtyCardQueue buffers #14365

Closed
wants to merge 2 commits into from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Jun 7, 2023

Please review this simple fix to the sorting of dirty card buffers. The
comparison function is using the difference between the card pointer to
compute the order, but is discarding all but the low 32 bits.

While I was at it, adjusted the name of the sort function.

Testing:
mach5 tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309627: Incorrect sorting of DirtyCardQueue buffers (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14365/head:pull/14365
$ git checkout pull/14365

Update a local copy of the PR:
$ git checkout pull/14365
$ git pull https://git.openjdk.org/jdk.git pull/14365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14365

View PR using the GUI difftool:
$ git pr show -t 14365

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14365.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2023

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 7, 2023
@openjdk
Copy link

openjdk bot commented Jun 7, 2023

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jun 7, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 7, 2023

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309627: Incorrect sorting of DirtyCardQueue buffers

Reviewed-by: ayang, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 7, 2023
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kimbarrett
Copy link
Author

Thanks for reviews @albertnetymk and @shipilev

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 10, 2023

Going to push as commit b94b679.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 10, 2023
@openjdk openjdk bot closed this Jun 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 10, 2023
@openjdk
Copy link

openjdk bot commented Jun 10, 2023

@kimbarrett Pushed as commit b94b679.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the dcq-sort branch June 10, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants