8309627: Incorrect sorting of DirtyCardQueue buffers

[kimbarrett]

Please review this simple fix to the sorting of dirty card buffers. The
comparison function is using the difference between the card pointer to
compute the order, but is discarding all but the low 32 bits.

While I was at it, adjusted the name of the sort function.

Testing:
mach5 tier1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309627: Incorrect sorting of DirtyCardQueue buffers (Bug - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14365/head:pull/14365
$ git checkout pull/14365

Update a local copy of the PR:
$ git checkout pull/14365
$ git pull https://git.openjdk.org/jdk.git pull/14365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14365

View PR using the GUI difftool:
$ git pr show -t 14365

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14365.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (fbffac70)
• 00: Full (dadf783d)

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309627: Incorrect sorting of DirtyCardQueue buffers

Reviewed-by: ayang, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Looks good!

[kimbarrett]

Thanks for reviews @albertnetymk and @shipilev

[kimbarrett]

/integrate

[openjdk]

Going to push as commit b94b679.

[openjdk]

@kimbarrett Pushed as commit b94b679.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.