Skip to content

8309499: javac fails to report compiler.err.no.java.lang with annotation processing enabled #14370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

8309499: javac fails to report compiler.err.no.java.lang with annotation processing enabled #14370

wants to merge 4 commits into from

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Jun 7, 2023 •
edited by openjdk bot
Loading

Hi,

Please consider this fix for an error handling bug in javac, which causes a deferred diagnostic to be lost when an Abort is thrown with annotation processing enabled. See https://bugs.openjdk.org/browse/JDK-8309499 for more details.

This fix is contributed by my colleague Paula Toth paulatoth@google.com.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309499: javac fails to report compiler.err.no.java.lang with annotation processing enabled (Bug - P3)

Reviewers

Contributors

  • Paula Toth <paulatoth@google.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14370/head:pull/14370
$ git checkout pull/14370

Update a local copy of the PR:
$ git checkout pull/14370
$ git pull https://git.openjdk.org/jdk.git pull/14370/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14370

View PR using the GUI difftool:
$ git pr show -t 14370

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14370.diff

Webrev

Link to Webrev Comment

@PaulkaToast @cushon
8309499: Don't swallow diagnostics with annotation processors.
d7ca4ad 
Within `initProcessAnnotations` a `deferredDiagnosticHandler` is
installed when annotation processing is enabled. Normally, when
`processAnnotations` is called after `enterTrees`, the
`processAnnotations` code calls `reportDeferredDiagnostics`. However, if
an Abort gets thrown in `enterTrees` (currently only when java.lang is
missing), no one ends up calling `reportDeferredDiagnostics` and these
diagnostics end up being lost.

This commit adds a call in the finally clause to catch this situation
and adds tests based on the existing NoJavaLang tests to ensure that
these errors bubble up even when annotation processors are enabled.
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2023

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@cushon
Copy link
Contributor Author

cushon commented Jun 7, 2023

/contributor add Paula Toth paulatoth@google.com

@openjdk
Copy link

openjdk bot commented Jun 7, 2023

@cushon Paula Toth paulatoth@google.com is not a valid name and email string.

Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@openjdk
Copy link

openjdk bot commented Jun 7, 2023

@cushon The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Jun 7, 2023
@cushon
Copy link
Contributor Author

cushon commented Jun 7, 2023

/contributor add Paula Toth paulatoth@google.com

@openjdk
Copy link

openjdk bot commented Jun 7, 2023

@cushon
Contributor Paula Toth <paulatoth@google.com> successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 7, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2023 •
edited
Loading

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 8, 2023 •
edited
Loading

@cushon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309499: javac fails to report compiler.err.no.java.lang with annotation processing enabled

Co-authored-by: Paula Toth <paulatoth@google.com>
Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 110 new commits pushed to the master branch:

  • 3e0bbd2: 8285368: Overhaul doc-comment inheritance
  • 3eeb681: 8167252: Some of Charset.availableCharsets() does not contain itself
  • 653a8d0: 8310129: SetupNativeCompilation LIBS should match the order of the other parameters
  • 947f149: 8308444: LoadStoreNode::result_not_used() is too conservative
  • 8b4af46: 8309974: some JVMCI tests fail when VM options include -XX:+EnableJVMCI
  • 0038491: 8309978: [x64] Fix useless padding
  • 5f3613e: 8309960: ParallelGC young collections very slow in DelayInducer
  • 83d9267: 8303513: C2: LoadKlassNode::make fails with 'expecting TypeKlassPtr'
  • de8aca2: 8307907: [ppc] Remove RTM locking implementation
  • 4c0e164: 8309717: C2: Remove Arena::move_contents usage
  • ... and 100 more: https://git.openjdk.org/jdk/compare/92beb85510a809b15c9bd5a4c19c305fc339a2c9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 8, 2023
@cushon
Copy link
Contributor Author

cushon commented Jun 16, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

Going to push as commit 53abba3.
Since your change was applied there have been 131 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 16, 2023
@openjdk openjdk bot closed this Jun 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@cushon Pushed as commit 53abba3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicente-romero-oracle vicente-romero-oracle vicente-romero-oracle approved these changes

Assignees
No one assigned
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cushon @vicente-romero-oracle @PaulkaToast