JDK-8309142: Refactor test/langtools/tools/javac/versions/Versions.java

[jddarcy]

Test refactoring to reduce future maintenance: when source version gets a new language feature, a single enum constant with an example gets added to test all source versions against that sample.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309142: Refactor test/langtools/tools/javac/versions/Versions.java (Enhancement - P4)

Reviewers

• Jonathan Gibbons (@jonathan-gibbons - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14387/head:pull/14387
$ git checkout pull/14387

Update a local copy of the PR:
$ git checkout pull/14387
$ git pull https://git.openjdk.org/jdk.git pull/14387/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14387

View PR using the GUI difftool:
$ git pr show -t 14387

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14387.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jddarcy The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b6f4bc0e)

[openjdk]

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309142: Refactor test/langtools/tools/javac/versions/Versions.java

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• cee5724: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property
• 7d6f97d: 8309673: Refactor ref_at methods in SA ConstantPool
• 7a970b2: 8309310: Update --release 21 symbol information for JDK 21 build 26
• 84184f9: 8232839: JDI AfterThreadDeathTest.java failed due to "FAILED: Did not get expected IllegalThreadStateException on a StepRequest.enable()"
• 679a6d8: 8309303: jdk/internal/misc/VM/RuntimeArguments test ignores jdk/internal/vm/options
• 6cd370e: 8305645: System Tray icons get corrupted when Windows primary monitor changes
• a48bcf3: 8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use
• c052756: 8282797: CompileCommand parsing errors should exit VM
• dc842e8: 8309665: Simplify Arrays.copyOf/-Range methods
• 3070856: 8309702: Exclude java/lang/ScopedValue/StressStackOverflow.java from JTREG_TEST_THREAD_FACTORY=Virtual runs
• ... and 8 more: https://git.openjdk.org/jdk/compare/bb966827ac445d805bac5005d0fbda0c61111252...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jddarcy]

/integrate

[openjdk]

Going to push as commit 7d82479.
Since your change was applied there have been 19 commits pushed to the master branch:

• f5ec93e: 8309745: Problem list open client tests failing on Ubuntu_23.04
• cee5724: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property
• 7d6f97d: 8309673: Refactor ref_at methods in SA ConstantPool
• 7a970b2: 8309310: Update --release 21 symbol information for JDK 21 build 26
• 84184f9: 8232839: JDI AfterThreadDeathTest.java failed due to "FAILED: Did not get expected IllegalThreadStateException on a StepRequest.enable()"
• 679a6d8: 8309303: jdk/internal/misc/VM/RuntimeArguments test ignores jdk/internal/vm/options
• 6cd370e: 8305645: System Tray icons get corrupted when Windows primary monitor changes
• a48bcf3: 8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use
• c052756: 8282797: CompileCommand parsing errors should exit VM
• dc842e8: 8309665: Simplify Arrays.copyOf/-Range methods
• ... and 9 more: https://git.openjdk.org/jdk/compare/bb966827ac445d805bac5005d0fbda0c61111252...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jddarcy Pushed as commit 7d82479.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.