-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" #14399
Conversation
👋 Welcome back aph! A progress list of the required criteria for merging this PR into |
@theRealAph The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
Hi Andrew, This test failure is no more reproducible on s390x now, would you consider undo-ing problemlisting done by JDK-8303499, I'll close the parent task JDK-8303498 |
One suggestion for the test is to have it re-run with -XX:-VMContinuations on platforms/ports that do do have VM continuations support. Some of the tests for virtual threads do the same thing to ensure this operating mode is tested. This should do it:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation changes look good.
The update to test looks okay too although I would like to see if we can do better in SVC and STS when there is a SO. In passing, I think all usages of tlr should be replaced with ThreadLocalRandom.current().
@theRealAph This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 85 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
That would be nice, but it's something of a can of worms.
OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably go further and drop the TLR parameter from the choose method too but what you have is fine, let's go with that.
/integrate |
Going to push as commit 44a8aa0.
Your commit was automatically rebased without conflicts. |
@theRealAph Pushed as commit 44a8aa0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I didn't spot this before it was integrated but test/hotspot/jtreg/serviceability/jvmti/thread/GetStackTrace/getstacktr03/libgetstacktr03.cpp is sensitive to the stack trace so its list of expected frames needs to be updated to take account of runWith no longer overridden in the sub-class. I've created JDK-8310211. |
@theRealAph - I've applied the fix that @AlanBateman proposed in JDK-8310211 |
Move
runWith()
fromVirtualThread
toBaseVirtualThread
.BoundVirtualThread
does not userunWith()
to run its task, so when a VM error occurs it can not recover scoped values.Moving
runWith()
into the common subclass of bothVirtualThread
andBoundVirtualThread
fixes the problem.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14399/head:pull/14399
$ git checkout pull/14399
Update a local copy of the PR:
$ git checkout pull/14399
$ git pull https://git.openjdk.org/jdk.git pull/14399/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14399
View PR using the GUI difftool:
$ git pr show -t 14399
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14399.diff
Webrev
Link to Webrev Comment