Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309760: ProblemList serviceability/jvmti/vthread/FollowReferences/VThreadStackRefTest.java#default with ZGC #14406

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jun 10, 2023

A trivial fix to ProblemList serviceability/jvmti/vthread/FollowReferences/VThreadStackRefTest.java#default with ZGC


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309760: ProblemList serviceability/jvmti/vthread/FollowReferences/VThreadStackRefTest.java#default with ZGC (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14406/head:pull/14406
$ git checkout pull/14406

Update a local copy of the PR:
$ git checkout pull/14406
$ git pull https://git.openjdk.org/jdk.git pull/14406/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14406

View PR using the GUI difftool:
$ git pr show -t 14406

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14406.diff

Webrev

Link to Webrev Comment

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add hotspot-gc

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review June 10, 2023 01:42
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Jun 10, 2023
@openjdk
Copy link

openjdk bot commented Jun 10, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jun 10, 2023
@openjdk
Copy link

openjdk bot commented Jun 10, 2023

@dcubed-ojdk
The hotspot-gc label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jun 10, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 10, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309760: ProblemList serviceability/jvmti/vthread/FollowReferences/VThreadStackRefTest.java#default with ZGC

Reviewed-by: amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 10, 2023
@dcubed-ojdk
Copy link
Member Author

@alexmenkov - Thanks for the Friday night review!

/integrate

@openjdk
Copy link

openjdk bot commented Jun 10, 2023

Going to push as commit aace3dc.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 10, 2023
@openjdk openjdk bot closed this Jun 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 10, 2023
@openjdk
Copy link

openjdk bot commented Jun 10, 2023

@dcubed-ojdk Pushed as commit aace3dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8309760 branch June 10, 2023 02:11
@dcubed-ojdk
Copy link
Member Author

/backport jdk21

@openjdk
Copy link

openjdk bot commented Jun 10, 2023

@dcubed-ojdk the backport was successfully created on the branch dcubed-ojdk-backport-aace3dc2 in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit aace3dc2 from the openjdk/jdk repository.

The commit being backported was authored by Daniel D. Daugherty on 10 Jun 2023 and was reviewed by Alex Menkov.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git dcubed-ojdk-backport-aace3dc2:dcubed-ojdk-backport-aace3dc2
$ git checkout dcubed-ojdk-backport-aace3dc2
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git dcubed-ojdk-backport-aace3dc2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants