8309838: Classfile API Util.toBinaryName and other cleanup

[liach]

Thanks to @ExE-Boss for the reviews in #13082. This cleanup patch fixed the typos you pointed out and removed other redundancies in classfile Util as well.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309838: Classfile API Util.toBinaryName and other cleanup (Enhancement - P4)

Reviewers

• Adam Sotona (@asotona - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14412/head:pull/14412
$ git checkout pull/14412

Update a local copy of the PR:
$ git checkout pull/14412
$ git pull https://git.openjdk.org/jdk.git pull/14412/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14412

View PR using the GUI difftool:
$ git pr show -t 14412

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14412.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (02befdd0)

[ExE-Boss]

Note that this method can get called with array class descriptors as well, so the correct implementation would be:

Suggested change

	public static String toBinaryName(ClassDesc cd) {
	return toInternalName(cd).replace('/', '.');
	}
	public static String toBinaryName(ClassDesc cd) {
	return (cd.isArray() ? cd.descriptorString() : toInternalName(cd))
	.replace('/', '.');
	}

[liach]

This isn't. We don't pass array classes to ClassHierarchyResolvers.

[liach]

@asotona Can you please review this when you are free?

[asotona]

It looks good 👍

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309838: Classfile API Util.toBinaryName and other cleanup

Reviewed-by: asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 5d71612: 8309852: G1: Remove unnecessary assert_empty in G1ParScanThreadStateSet destructor
• 23a54f3: 8309538: G1: Move total collection increment from Cleanup to Remark
• 57fc9a3: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader
• 2dca5ae: 8299052: ViewportOverlapping test fails intermittently on Win10 & Win11
• 3028295: 8309065: Move the logic to determine archive heap location from CDS to G1 GC
• 80a8144: 8309867: redundant class field RSAPadding.md
• 3c15ad8: 8307144: namedParams in XECParameters and EdDSAParameters can be private final
• 3ce1240: 8309870: Using -proc:full should be considered requesting explicit annotation processing
• 1612b6d: 8309752: com/sun/jdi/SetLocalWhileThreadInNative.java fails with virtual test thread factory due to OpaqueFrameException
• 45414fc: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries
• ... and 11 more: https://git.openjdk.org/jdk/compare/6c3e621f9818fe764501e1a72c7cf8e9803da683...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@asotona) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[liach]

/integrate

[openjdk]

@liach
Your change (at version 02befdd) is now ready to be sponsored by a Committer.

[asotona]

/sponsor

[openjdk]

Going to push as commit 1a9edb8.
Since your change was applied there have been 22 commits pushed to the master branch:

• f7de726: 8295555: Primitive wrapper caches could be @Stable
• 5d71612: 8309852: G1: Remove unnecessary assert_empty in G1ParScanThreadStateSet destructor
• 23a54f3: 8309538: G1: Move total collection increment from Cleanup to Remark
• 57fc9a3: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader
• 2dca5ae: 8299052: ViewportOverlapping test fails intermittently on Win10 & Win11
• 3028295: 8309065: Move the logic to determine archive heap location from CDS to G1 GC
• 80a8144: 8309867: redundant class field RSAPadding.md
• 3c15ad8: 8307144: namedParams in XECParameters and EdDSAParameters can be private final
• 3ce1240: 8309870: Using -proc:full should be considered requesting explicit annotation processing
• 1612b6d: 8309752: com/sun/jdi/SetLocalWhileThreadInNative.java fails with virtual test thread factory due to OpaqueFrameException
• ... and 12 more: https://git.openjdk.org/jdk/compare/6c3e621f9818fe764501e1a72c7cf8e9803da683...master

Your commit was automatically rebased without conflicts.

[openjdk]

@asotona @liach Pushed as commit 1a9edb8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.