Skip to content

8309852: G1: Remove unnecessary assert_empty in G1ParScanThreadStateSet destructor #14417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jun 12, 2023

Trivial removing redundant code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309852: G1: Remove unnecessary assert_empty in G1ParScanThreadStateSet destructor (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14417/head:pull/14417
$ git checkout pull/14417

Update a local copy of the PR:
$ git checkout pull/14417
$ git pull https://git.openjdk.org/jdk.git pull/14417/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14417

View PR using the GUI difftool:
$ git pr show -t 14417

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14417.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 12, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8309852 8309852: G1: Remove unnecessary assert_empty in G1ParScanThreadStateSet destructor Jun 12, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 12, 2023
@openjdk
Copy link

openjdk bot commented Jun 12, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jun 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 12, 2023

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please copy&paste the description of the CR into the PR description for easier reference :)

@openjdk
Copy link

openjdk bot commented Jun 12, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309852: G1: Remove unnecessary assert_empty in G1ParScanThreadStateSet destructor

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 8e4e6b0: 8309761: Leak class loader constraints

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 12, 2023
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 13, 2023

Going to push as commit 5d71612.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 23a54f3: 8309538: G1: Move total collection increment from Cleanup to Remark
  • 57fc9a3: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader
  • 2dca5ae: 8299052: ViewportOverlapping test fails intermittently on Win10 & Win11
  • 3028295: 8309065: Move the logic to determine archive heap location from CDS to G1 GC
  • 80a8144: 8309867: redundant class field RSAPadding.md
  • 3c15ad8: 8307144: namedParams in XECParameters and EdDSAParameters can be private final
  • 3ce1240: 8309870: Using -proc:full should be considered requesting explicit annotation processing
  • 1612b6d: 8309752: com/sun/jdi/SetLocalWhileThreadInNative.java fails with virtual test thread factory due to OpaqueFrameException
  • 45414fc: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries
  • a6ad42e: 8308645: Javadoc of FFM API needs to be refreshed
  • ... and 4 more: https://git.openjdk.org/jdk/compare/fdaa2c40835344a336696656285d8a9705f4a166...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 13, 2023
@openjdk openjdk bot closed this Jun 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 13, 2023
@openjdk
Copy link

openjdk bot commented Jun 13, 2023

@albertnetymk Pushed as commit 5d71612.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the g1-preserved-marks-set-assert branch February 16, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants