Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257083: Security infra test failures caused by JDK-8202343 #1442

Closed
wants to merge 1 commit into from

Conversation

seanjmullan
Copy link
Member

@seanjmullan seanjmullan commented Nov 25, 2020

There are several infra test failures that were caused by the fix for JDK-8202343 (Disable TLS 1.0 and 1.1).

The problem is that test/jdk/javax/net/ssl/TLSCommon/interop/JdkProcClient.java is designed to be run with different versions of the JDK such as JDK 8 but now calls SecurityUtils.removeFromDisabledTlsAlgs() which calls APIs such as List.of() that are not available in JDK 8.

The fix is to create a private method which does the same thing as SecurityUtils.removeFromDisabledTlsAlgs() but doesn't depend on newer APIs.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux additional Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (8/8 passed) ✔️ (2/2 passed) (2/2 failed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Failed test tasks

Issue

  • JDK-8257083: Security infra test failures caused by JDK-8202343

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1442/head:pull/1442
$ git checkout pull/1442

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2020

👋 Welcome back mullan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 25, 2020
@openjdk
Copy link

openjdk bot commented Nov 25, 2020

@seanjmullan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Nov 25, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 25, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 25, 2020

@seanjmullan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257083: Security infra test failures caused by JDK-8202343

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 20020d1: 8254360: Re-examine use of CodeBuffer::verify_section_allocation
  • e56a8df: 8257042: [aix] Disable os.release_one_mapping_multi_commits_vm gtest
  • 9d7121c: 8256713: SwingSet2 : Slider leaves tracks in uiScale=2
  • 434b98f: 8257077: ZGC: Remove ZWorkers::run_serial()
  • f3fc0e0: 8257079: ZGC: Fold ZMark::prepare_mark() into ZMark::start()
  • a14f02d: 8256267: Relax compiler/floatingpoint/NaNTest.java for x86_32 and lower -XX:+UseSSE
  • 7c73fff: 8256486: Linux/Windows-x86 builds broken after JDK-8254231
  • 461c5fc: 8256450: Add gz option to jmap to write a gzipped heap dump
  • dee79d6: 8253936: Replace ... with {@code ...} for java.sql

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 25, 2020
@seanjmullan
Copy link
Member Author

seanjmullan commented Nov 30, 2020

/integrate

@openjdk openjdk bot closed this Nov 30, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 30, 2020
@openjdk
Copy link

openjdk bot commented Nov 30, 2020

@seanjmullan Since your change was applied there have been 55 commits pushed to the master branch:

  • 4db05e9: 8254042: gtest/GTestWrapper.java failed os.test_random
  • 962f7a3: 8257162: Initialize ThreadLocalAllocBuffer members
  • 337d7bc: 8257165: C2: Improve box elimination for vector masks and shuffles
  • 4e55d0f: 8257057: C2: Improve safepoint processing during vector scalarization pass
  • e77aed6: 8256754: Deoptimization::revoke_for_object_deoptimization: stack processing start call is redundant
  • 738efea: 8248564: JFR: Remote Recording Stream
  • 9bcd269: 8257221: C2: RegMask::is_bound_set split set handling broken since JDK-8221404
  • 222e943: 8257238: Cleanup include directives for precompiled.hpp
  • fdee70d: 8257237: Cleanup unused imports in the SunJSSE provider implementation
  • 816e8f8: 8256999: Add C2 intrinsic for Reference.refersTo and PhantomReference::refersTo
  • ... and 45 more: https://git.openjdk.java.net/jdk/compare/cfb175dfdfd57a3da1d0dbc251657312abc0f6f3...master

Your commit was automatically rebased without conflicts.

Pushed as commit c071960.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
2 participants