Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309867: redundant class field RSAPadding.md #14422

Closed
wants to merge 1 commit into from

Conversation

XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Jun 12, 2023

Hi,

May I get this simple update reviewed?

The class field RSAPadding.md can be converted to a local variable of the constructor, and save the class footprint.

Thanks,
Xuelei


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309867: redundant class field RSAPadding.md (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14422/head:pull/14422
$ git checkout pull/14422

Update a local copy of the PR:
$ git checkout pull/14422
$ git pull https://git.openjdk.org/jdk.git pull/14422/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14422

View PR using the GUI difftool:
$ git pr show -t 14422

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14422.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 12, 2023

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 12, 2023

@XueleiFan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jun 12, 2023
@XueleiFan XueleiFan marked this pull request as ready for review June 12, 2023 16:45
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 12, 2023

Webrevs

@haimaychao
Copy link
Contributor

LGTM

@openjdk
Copy link

openjdk bot commented Jun 12, 2023

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309867: redundant class field RSAPadding.md

Reviewed-by: hchao, weijun, valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 3ce1240: 8309870: Using -proc:full should be considered requesting explicit annotation processing
  • 1612b6d: 8309752: com/sun/jdi/SetLocalWhileThreadInNative.java fails with virtual test thread factory due to OpaqueFrameException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 12, 2023
@XueleiFan
Copy link
Member Author

Thank you @haimaychao and @wangweij!

Copy link
Member

@seanjmullan seanjmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd be more inclined to call this a Bug than an Enhancement.

@XueleiFan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 12, 2023

Going to push as commit 80a8144.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 3c15ad8: 8307144: namedParams in XECParameters and EdDSAParameters can be private final
  • 3ce1240: 8309870: Using -proc:full should be considered requesting explicit annotation processing
  • 1612b6d: 8309752: com/sun/jdi/SetLocalWhileThreadInNative.java fails with virtual test thread factory due to OpaqueFrameException

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 12, 2023
@openjdk openjdk bot closed this Jun 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 12, 2023
@openjdk
Copy link

openjdk bot commented Jun 12, 2023

@XueleiFan Pushed as commit 80a8144.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XueleiFan XueleiFan deleted the JDK-8309867 branch June 12, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
5 participants