8309862: Unsafe list operations in JfrStringPool

[mgronlun]

Greetings,

please help review this fix to unsafe list operations in the JfrStringPool.

Details are in the JIRA issues.

Testing: jdk_jfr, stress testing.

Thanks
Markus

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309862: Unsafe list operations in JfrStringPool (Bug - P2)

Reviewers

• Erik Gahlin (@egahlin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14426/head:pull/14426
$ git checkout pull/14426

Update a local copy of the PR:
$ git checkout pull/14426
$ git pull https://git.openjdk.org/jdk.git pull/14426/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14426

View PR using the GUI difftool:
$ git pr show -t 14426

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14426.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mgronlun The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3dbd0081)

[openjdk]

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309862: Unsafe list operations in JfrStringPool

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 4f23fc1: 8309671: Avoid using jvmci.Compiler property to determine if Graal is enabled
• 1a9edb8: 8309838: Classfile API Util.toBinaryName and other cleanup
• f7de726: 8295555: Primitive wrapper caches could be @Stable
• 5d71612: 8309852: G1: Remove unnecessary assert_empty in G1ParScanThreadStateSet destructor
• 23a54f3: 8309538: G1: Move total collection increment from Cleanup to Remark
• 57fc9a3: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader
• 2dca5ae: 8299052: ViewportOverlapping test fails intermittently on Win10 & Win11
• 3028295: 8309065: Move the logic to determine archive heap location from CDS to G1 GC
• 80a8144: 8309867: redundant class field RSAPadding.md
• 3c15ad8: 8307144: namedParams in XECParameters and EdDSAParameters can be private final

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mgronlun]

/integrate

[openjdk]

Going to push as commit 05f896a.
Since your change was applied there have been 10 commits pushed to the master branch:

• 4f23fc1: 8309671: Avoid using jvmci.Compiler property to determine if Graal is enabled
• 1a9edb8: 8309838: Classfile API Util.toBinaryName and other cleanup
• f7de726: 8295555: Primitive wrapper caches could be @Stable
• 5d71612: 8309852: G1: Remove unnecessary assert_empty in G1ParScanThreadStateSet destructor
• 23a54f3: 8309538: G1: Move total collection increment from Cleanup to Remark
• 57fc9a3: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader
• 2dca5ae: 8299052: ViewportOverlapping test fails intermittently on Win10 & Win11
• 3028295: 8309065: Move the logic to determine archive heap location from CDS to G1 GC
• 80a8144: 8309867: redundant class field RSAPadding.md
• 3c15ad8: 8307144: namedParams in XECParameters and EdDSAParameters can be private final

Your commit was automatically rebased without conflicts.

[openjdk]

@mgronlun Pushed as commit 05f896a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mgronlun]

/backport jdk21

[openjdk]

@mgronlun the backport was successfully created on the branch mgronlun-backport-05f896a1 in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 05f896a1 from the openjdk/jdk repository.

The commit being backported was authored by Markus Grönlund on 13 Jun 2023 and was reviewed by Erik Gahlin.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git mgronlun-backport-05f896a1:mgronlun-backport-05f896a1
$ git checkout mgronlun-backport-05f896a1
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git mgronlun-backport-05f896a1