JDK-8309883: no @since info in com.sun.tools.javac package-info.java, Main.java

[jonathan-gibbons]

Please review a trivial update to add some long-overdue @since tags to public API in com.sun.tools.javac.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309883: no @since info in com.sun.tools.javac package-info.java, Main.java (Bug - P4)

Reviewers

• Iris Clark (@irisclark - Reviewer)
• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14431/head:pull/14431
$ git checkout pull/14431

Update a local copy of the PR:
$ git checkout pull/14431
$ git pull https://git.openjdk.org/jdk.git pull/14431/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14431

View PR using the GUI difftool:
$ git pr show -t 14431

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14431.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jonathan-gibbons The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fda58e1f)

[irisclark]

Wow. Surprised to see that one escape for so long!

[jonathan-gibbons]

Wow. Surprised to see that one escape for so long!

Nothing like this surprises me any more!

[openjdk]

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309883: no `@since` info in com.sun.tools.javac package-info.java, Main.java

Reviewed-by: iris, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 123 new commits pushed to the master branch:

• 72501cf: 8310379: Relax prerequisites for java.base-jmod target
• 59c6c0e: 8310335: JFR: Modernize collections and switch statements
• 826dcb5: 8264899: C1: -XX:AbortVMOnException does not work if all methods in the call stack are compiled with C1 and there are no exception handlers
• 658c337: 8309296: jdk/jfr/event/runtime/TestAgentEvent.java fails due to "missing" dynamic JavaAgent
• 70e1c92: 8310297: assert(static_cast(result) == thing) with ctw
• 574c6f0: 8310376: Extend SetupTarget macro with DIR parameter
• 7ea22cd: 8310369: UTIL_ARG_WITH fails when arg is disabled
• 01623f6: 8310133: Effectivelly final condition not enforced in guards for binding variables from the same case
• a15db1a: 8302865: Illegal bytecode for break from if with instanceof pattern matching condition
• 67fbd87: 8310143: RandomCommandsTest fails due to unexpected VM exit code after JDK-8282797
• ... and 113 more: https://git.openjdk.org/jdk/compare/3028295fdd2e5caf22463d1ee8009e72d4221d53...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jonathan-gibbons]

/integrate

[openjdk]

Going to push as commit 226c6a0.
Since your change was applied there have been 124 commits pushed to the master branch:

• fd1163d: 8310332: Fix -Wconversion warnings in MethodData
• 72501cf: 8310379: Relax prerequisites for java.base-jmod target
• 59c6c0e: 8310335: JFR: Modernize collections and switch statements
• 826dcb5: 8264899: C1: -XX:AbortVMOnException does not work if all methods in the call stack are compiled with C1 and there are no exception handlers
• 658c337: 8309296: jdk/jfr/event/runtime/TestAgentEvent.java fails due to "missing" dynamic JavaAgent
• 70e1c92: 8310297: assert(static_cast(result) == thing) with ctw
• 574c6f0: 8310376: Extend SetupTarget macro with DIR parameter
• 7ea22cd: 8310369: UTIL_ARG_WITH fails when arg is disabled
• 01623f6: 8310133: Effectivelly final condition not enforced in guards for binding variables from the same case
• a15db1a: 8302865: Illegal bytecode for break from if with instanceof pattern matching condition
• ... and 114 more: https://git.openjdk.org/jdk/compare/3028295fdd2e5caf22463d1ee8009e72d4221d53...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jonathan-gibbons Pushed as commit 226c6a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.