8309601: [JVMCI] AMD64#getLargestStorableKind returns incorrect mask kind

[gergo-]

jdk.vm.ci.amd64.AMD64#getLargestStorableKind(RegisterCategory) unconditionally returns AMD64Kind.MASK64 for mask registers. This is only correct if the target supports AVX512BW. On other AVX512 versions this should be MASK16.

The Graal compiler uses this method to determine how to spill a given register. An incorrect size will lead to compilation errors due to trying to emit a move with a size that is not supported by the target. I have manually verified that this fixes those problems.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309601: [JVMCI] AMD64#getLargestStorableKind returns incorrect mask kind (Bug - P4)

Reviewers

• Doug Simon (@dougxc - Committer)
• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14441/head:pull/14441
$ git checkout pull/14441

Update a local copy of the PR:
$ git checkout pull/14441
$ git pull https://git.openjdk.org/jdk.git pull/14441/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14441

View PR using the GUI difftool:
$ git pr show -t 14441

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14441.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @gergo-, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user gergo-" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@gergo- The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[gergo-]

/covered

[bridgekeeper]

You are already a known contributor!

[mlbridge]

Webrevs

• 00: Full (b94cb066)

[tkrodriguez]

Looks good

[openjdk]

@gergo- This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309601: [JVMCI] AMD64#getLargestStorableKind returns incorrect mask kind

Reviewed-by: dnsimon, never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 110 new commits pushed to the master branch:

• 16134f4: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing
• d6c2ee3: 8310054: ScrollPane insets are incorrect
• 4eb4f20: 8308808: SunMSCAPI public keys returns internal key array
• 53abba3: 8309499: javac fails to report compiler.err.no.java.lang with annotation processing enabled
• cf8d0b0: 8309964: Use directed inheritDoc for javax.lang.model API
• a45f929: 8310076: Reduce inclusion of bytecodeStream.hpp
• 21f6d83: 8309471: Limit key characters in static index pages
• 44a8aa0: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations"
• b412fc7: 8309937: Add @sealedGraph for some Panama FFM interfaces
• fb024fd: 8248149: G1: change _cleaning_claimed from int to bool
• ... and 100 more: https://git.openjdk.org/jdk/compare/c052756154603a9d3a13200fa407a2dc124437f3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dougxc, @tkrodriguez) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[gergo-]

/integrate

[openjdk]

@gergo-
Your change (at version b94cb06) is now ready to be sponsored by a Committer.

[tkrodriguez]

The linux-x86 failure looks unrelated so the testing looks clean to me.

/sponsor

[openjdk]

Going to push as commit 492d25c.
Since your change was applied there have been 113 commits pushed to the master branch:

• 959a61f: 8310259: Pin msys2/setup-msys2 github action to a specific commit
• bcc4d36: 8309511: Regression test ExtraImportSemicolon.java refers to the wrong bug
• 71baf00: 8309605: StubRoutines are not used by SA
• 16134f4: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing
• d6c2ee3: 8310054: ScrollPane insets are incorrect
• 4eb4f20: 8308808: SunMSCAPI public keys returns internal key array
• 53abba3: 8309499: javac fails to report compiler.err.no.java.lang with annotation processing enabled
• cf8d0b0: 8309964: Use directed inheritDoc for javax.lang.model API
• a45f929: 8310076: Reduce inclusion of bytecodeStream.hpp
• 21f6d83: 8309471: Limit key characters in static index pages
• ... and 103 more: https://git.openjdk.org/jdk/compare/c052756154603a9d3a13200fa407a2dc124437f3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tkrodriguez @gergo- Pushed as commit 492d25c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.