JDK-8309934: Update GitHub Actions to use JDK 17 for building jtreg

[sormuras]

Please review this change to use the pre-installed JDK 17 for building jtreg when running on GitHub Actions.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309934: Update GitHub Actions to use JDK 17 for building jtreg (Bug - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14448/head:pull/14448
$ git checkout pull/14448

Update a local copy of the PR:
$ git checkout pull/14448
$ git pull https://git.openjdk.org/jdk.git pull/14448/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14448

View PR using the GUI difftool:
$ git pr show -t 14448

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14448.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sormuras The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (431ce0c3)
• 00: Full (cc05a40e)

[openjdk]

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309934: Update GitHub Actions to use JDK 17 for building jtreg

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• e138685: 8309882: LinkedHashMap adds an errant serializable field
• c0aa6bf: 8309390: [JVMCI] improve copying system properties into libgraal
• 63843b1: 8309907: Remove unused _print_gc_overhead_limit_would_be_exceeded
• 6d05360: 8304403: Remove unused methods in RangeCheckElimination::Bound
• 9b0baa1: 8306281: function isWsl() returns false on WSL2
• c884862: 8309468: Remove jvmti Allocate locker test case

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sormuras]

/integrate

[openjdk]

Going to push as commit 8aad881.
Since your change was applied there have been 14 commits pushed to the master branch:

• 9bfe415: 8305104: Remove the old core reflection implementation
• bfef3c3: 8309955: Matcher uses @SInCE {@inheritdoc}
• d7251c1: 8309757: com/sun/jdi/ReferrersTest.java fails with virtual test thread factory
• b5b5b7c: 8309884: missing @SInCE tags in com.sun.source.*
• 75dcc4e: 8307508: IndirectVarHandle.isAccessModeSupported throws NPE
• bed9161: 8308474: DSA does not reset SecureRandom when initSign is called again
• 3eec179: 8309854: ciReplay TestServerVM test fails with Graal
• 1401087: 8309753: Include array classes in the output of -XX:+PrintSharedArchiveAndExit
• e138685: 8309882: LinkedHashMap adds an errant serializable field
• c0aa6bf: 8309390: [JVMCI] improve copying system properties into libgraal
• ... and 4 more: https://git.openjdk.org/jdk/compare/05f896a153ee950b21bae251d2870a8adfe4f04a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sormuras Pushed as commit 8aad881.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[tstuefe]

Do you know why this helped?

Will you downport this to JDK 17 too?

[sormuras]

Do you know why this helped?

No, unfortunately not: "Switching from 11 to 17 seems to mend the (unknown underlying) issue for the time being."
A test build using the same JDK as pre-installed on GitHub-hosted runners on my local machine did not fail either.

Will you downport this to JDK 17 too?

No. JDK 17 is archived and it uses JDK 8 to build jtreg within a single-file workflow definition:

• https://github.com/openjdk/jdk17/blob/master/.github/workflows/submit.yml#L88

A backport to JDK 21 makes sense.

[sormuras]

/backport jdk21

[openjdk]

@sormuras the backport was successfully created on the branch sormuras-backport-8aad881e in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 8aad881e from the openjdk/jdk repository.

The commit being backported was authored by Christian Stein on 13 Jun 2023 and was reviewed by Erik Joelsson.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git sormuras-backport-8aad881e:sormuras-backport-8aad881e
$ git checkout sormuras-backport-8aad881e
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git sormuras-backport-8aad881e

[tstuefe]

Will you downport this to JDK 17 too?

No. JDK 17 is archived and it uses JDK 8 to build jtreg within a single-file workflow definition:

* https://github.com/openjdk/jdk17/blob/master/.github/workflows/submit.yml#L88

Sorry, my mistake, I looked at the wrong test results.