Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309959: JFR: Display N/A for missing data amount #14454

Closed
wants to merge 1 commit into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Jun 13, 2023

Could I have a review of a follow up fix to JDK-8309550.

Testing: jdk/jdk/jfr

Plan is to clean up the formatting of missing values after, or during, refactoring of ValueFormatter, but this will done as an enhancement as it involves larger code changes.

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309959: JFR: Display N/A for missing data amount (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14454/head:pull/14454
$ git checkout pull/14454

Update a local copy of the PR:
$ git checkout pull/14454
$ git pull https://git.openjdk.org/jdk.git pull/14454/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14454

View PR using the GUI difftool:
$ git pr show -t 14454

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14454.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2023

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 13, 2023

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Jun 13, 2023
@egahlin egahlin marked this pull request as ready for review June 13, 2023 18:45
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 13, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 13, 2023

Webrevs

@egahlin egahlin changed the title 8309959 JFR: Display N/A for missing data amount 8309959: JFR: Display N/A for missing data amount Jun 13, 2023
@openjdk
Copy link

openjdk bot commented Jun 14, 2023

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309959: JFR: Display N/A for missing data amount

Reviewed-by: mgronlun, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • bd79db3: 8309613: [Windows] hs_err files sometimes miss information about the code containing the error
  • 63fe413: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition
  • ba837b4: 8309910: Introduce jdk.internal.net.http.HttpConnection.getSNIServerNames() method
  • 5d19319: 8309878: Reduce inclusion of resolvedIndyEntry.hpp
  • 8aad881: 8309934: Update GitHub Actions to use JDK 17 for building jtreg
  • 9bfe415: 8305104: Remove the old core reflection implementation
  • bfef3c3: 8309955: Matcher uses @SInCE {@inheritdoc}
  • d7251c1: 8309757: com/sun/jdi/ReferrersTest.java fails with virtual test thread factory

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 14, 2023
Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egahlin
Copy link
Member Author

egahlin commented Jun 14, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 14, 2023

Going to push as commit 9872a14.
Since your change was applied there have been 11 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 14, 2023
@openjdk openjdk bot closed this Jun 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 14, 2023
@openjdk
Copy link

openjdk bot commented Jun 14, 2023

@egahlin Pushed as commit 9872a14.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
3 participants