8309746: Reconfigure check should include make/conf/version-numbers.conf

[erikj79]

When we bump the JDK version, we need to reconfigure to get a working build. Users were reporting that this didn't happen automatically, or wasn't warned about, after pulling down that change. This patch addresses that by adding the files in the make/conf dir that are read by configure to the rule that checks the need for reconfigure.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309746: Reconfigure check should include make/conf/version-numbers.conf (Enhancement - P4)

Reviewers

• Mikael Vidstedt (@vidmik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14458/head:pull/14458
$ git checkout pull/14458

Update a local copy of the PR:
$ git checkout pull/14458
$ git pull https://git.openjdk.org/jdk.git pull/14458/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14458

View PR using the GUI difftool:
$ git pr show -t 14458

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14458.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@erikj79 The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c6702c74)
• 00: Full (4a633eeb)

[openjdk]

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309746: Reconfigure check should include make/conf/version-numbers.conf

Reviewed-by: mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[erikj79]

/integrate

[openjdk]

Going to push as commit 955fc2f.
Since your change was applied there have been 10 commits pushed to the master branch:

• 554b4d7: 8308585: AC_REQUIRE: `PLATFORM_EXTRACT_TARGET_AND_BUILD' was expanded before it was required
• 84d010a: 8309928: JFR: View issues
• 9872a14: 8309959: JFR: Display N/A for missing data amount
• 4c18b9e: 8309880: Add support for linking libffi on Windows and Mac
• 1d1ed0d: 8309957: Rename JDK-8309595 test to conform
• e3d6fc8: 8309847: FrameForm and RegisterForm constructors should initialize all members
• bd79db3: 8309613: [Windows] hs_err files sometimes miss information about the code containing the error
• 63fe413: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition
• ba837b4: 8309910: Introduce jdk.internal.net.http.HttpConnection.getSNIServerNames() method
• 5d19319: 8309878: Reduce inclusion of resolvedIndyEntry.hpp

Your commit was automatically rebased without conflicts.

[openjdk]

@erikj79 Pushed as commit 955fc2f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.