Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257148: Remove obsolete code in AWTView.m #1446

Closed
wants to merge 1 commit into from

Conversation

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Nov 26, 2020


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux additional Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (8/8 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) (2/9 failed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Failed test tasks

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1446/head:pull/1446
$ git checkout pull/1446

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 26, 2020

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2020

@VladimirKempik The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Nov 26, 2020
@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Nov 26, 2020

Hello
Please review this fix for jdk-8257148
The AWTView.m has some checks for very old version of macos unsupported by openjdk.

also the code in OSVersion.m uses system's API which are intel-only in macos big sur.

Removing this cleans up JDK.

@openjdk openjdk bot added the rfr label Nov 26, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 26, 2020

Webrevs

mrserb
mrserb approved these changes Nov 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2020

@VladimirKempik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257148: Remove obsolete code in AWTView.m

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 29, 2020
@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Nov 29, 2020

/integrate

@openjdk openjdk bot closed this Nov 29, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2020

@VladimirKempik Since your change was applied there have been 31 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit c2af27b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the JDK-8257148 branch Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants