8308499: Test vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter001/TestDescription.java failed: VMDisconnectedException

[plummercj]

The test gets overloaded with MethodExitEvents, causing them to queue up (in the JDI queue) and continue to be processed by the test after the debuggee exits. This results in a VMDisconnectedException when the test tries to do the following after getting an event:

String str = ((MethodExitEvent)event).location().declaringType().name();

The test is suppose to add filters to execlude events for all non-test classes, but it is only filtering java.* and sun.*. There are also a very large number of jdk.* events coming in, and this is what is causing the event backlog and the processing of events after disconnect. Filtering out jdk.* events reduces the total number of events to a few dozen, and the test passes.

More details can be found in the CR.

Testing in progress: tier5 svc testing, and also running the failing test on all platforms (both debug and product).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308499: Test vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter001/TestDescription.java failed: VMDisconnectedException (Bug - P4)

Reviewers

• Leonid Mesnik (@lmesnik - Reviewer)
• Kevin Walls (@kevinjwalls - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14480/head:pull/14480
$ git checkout pull/14480

Update a local copy of the PR:
$ git checkout pull/14480
$ git pull https://git.openjdk.org/jdk.git pull/14480/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14480

View PR using the GUI difftool:
$ git pr show -t 14480

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14480.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (dadeda84)

[lmesnik]

The fix is reasonable. However,
I think it would be better to use List with List.of(...) and list.contains() to filter exclusions.

[plummercj]

With 3 items it's borderline which approach to do. I find it easier to read the way it is now, especially checking the event classname, since it would require a loop that sets a flag that then has to be checked outside of the loop.

[lmesnik]

If you think it is easier, then fine.

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308499: Test vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter001/TestDescription.java failed: VMDisconnectedException

Reviewed-by: lmesnik, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 3e0bbd2: 8285368: Overhaul doc-comment inheritance
• 3eeb681: 8167252: Some of Charset.availableCharsets() does not contain itself
• 653a8d0: 8310129: SetupNativeCompilation LIBS should match the order of the other parameters
• 947f149: 8308444: LoadStoreNode::result_not_used() is too conservative
• 8b4af46: 8309974: some JVMCI tests fail when VM options include -XX:+EnableJVMCI
• 0038491: 8309978: [x64] Fix useless padding
• 5f3613e: 8309960: ParallelGC young collections very slow in DelayInducer
• 83d9267: 8303513: C2: LoadKlassNode::make fails with 'expecting TypeKlassPtr'
• de8aca2: 8307907: [ppc] Remove RTM locking implementation
• 4c0e164: 8309717: C2: Remove Arena::move_contents usage
• ... and 2 more: https://git.openjdk.org/jdk/compare/931625a9304ec2761ca9035d69fd33f6beadb124...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

Thanks for the reviews Leonid and Kevin!

/integrate

[openjdk]

Going to push as commit 79ff72a.
Since your change was applied there have been 12 commits pushed to the master branch:

• 3e0bbd2: 8285368: Overhaul doc-comment inheritance
• 3eeb681: 8167252: Some of Charset.availableCharsets() does not contain itself
• 653a8d0: 8310129: SetupNativeCompilation LIBS should match the order of the other parameters
• 947f149: 8308444: LoadStoreNode::result_not_used() is too conservative
• 8b4af46: 8309974: some JVMCI tests fail when VM options include -XX:+EnableJVMCI
• 0038491: 8309978: [x64] Fix useless padding
• 5f3613e: 8309960: ParallelGC young collections very slow in DelayInducer
• 83d9267: 8303513: C2: LoadKlassNode::make fails with 'expecting TypeKlassPtr'
• de8aca2: 8307907: [ppc] Remove RTM locking implementation
• 4c0e164: 8309717: C2: Remove Arena::move_contents usage
• ... and 2 more: https://git.openjdk.org/jdk/compare/931625a9304ec2761ca9035d69fd33f6beadb124...master

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit 79ff72a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.