Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310128: Switch with unnamed patterns erroneously non-exhaustive #14488

Closed
wants to merge 3 commits into from

Conversation

biboudis
Copy link
Member

@biboudis biboudis commented Jun 15, 2023

When a record pattern has an unnamed pattern with the type of the corresponding record component being primitive, the switch is erroneously deemed as non-exhaustive. This PR addresses this issue by introducing the correct type for unnamed patterns during exhaustivity check.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310128: Switch with unnamed patterns erroneously non-exhaustive (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14488/head:pull/14488
$ git checkout pull/14488

Update a local copy of the PR:
$ git checkout pull/14488
$ git pull https://git.openjdk.org/jdk.git pull/14488/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14488

View PR using the GUI difftool:
$ git pr show -t 14488

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14488.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2023

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 15, 2023
@biboudis
Copy link
Member Author

/backport jdk21

@openjdk
Copy link

openjdk bot commented Jun 15, 2023

@biboudis The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Jun 15, 2023
@openjdk
Copy link

openjdk bot commented Jun 15, 2023

@biboudis Backport for repo openjdk/jdk21 on branch master was successfully enabled and will be performed once this pull request has been integrated. Further instructions will be provided at that time.

@mlbridge
Copy link

mlbridge bot commented Jun 15, 2023

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit comment

@@ -3501,7 +3501,7 @@ public PatternDescription makePatternDescription(Type selectorType, JCPattern pa
}
return new RecordPattern(record.type, componentTypes, nestedDescriptions);
} else if (pattern instanceof JCAnyPattern) {
Type type = types.isSubtype(selectorType, syms.objectType)
Type type = types.isSubtype(selectorType, syms.objectType) || selectorType.isPrimitive()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to me like we can drop this condition and just use the selectorType

@openjdk
Copy link

openjdk bot commented Jun 15, 2023

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310128: Switch with unnamed patterns erroneously non-exhaustive

Reviewed-by: vromero, jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 5c70516: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent
  • 81bfd78: 8309632: JDK 21 RDP1 L10n resource files update
  • 9f64a64: 8301379: Verify TLS_ECDH_* cipher suites cannot be negotiated
  • 4a5475c: 8309953: Strengthen and optimize oopDesc age methods
  • 79ff72a: 8308499: Test vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter001/TestDescription.java failed: VMDisconnectedException
  • 3e0bbd2: 8285368: Overhaul doc-comment inheritance
  • 3eeb681: 8167252: Some of Charset.availableCharsets() does not contain itself
  • 653a8d0: 8310129: SetupNativeCompilation LIBS should match the order of the other parameters
  • 947f149: 8308444: LoadStoreNode::result_not_used() is too conservative

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle, @lahodaj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 15, 2023
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@biboudis
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 15, 2023
@openjdk
Copy link

openjdk bot commented Jun 15, 2023

@biboudis
Your change (at version f7aa8a1) is now ready to be sponsored by a Committer.

@lahodaj
Copy link
Contributor

lahodaj commented Jun 16, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

Going to push as commit 32243ef.
Since your change was applied there have been 14 commits pushed to the master branch:

  • cfae6ef: 8309778: java/nio/file/Files/CopyAndMove.java fails when using second test directory
  • db133db: 8310106: sun.security.ssl.SSLHandshake.getHandshakeProducer() incorrectly checks handshakeConsumers
  • 353e581: 8309747: Update --release 21 symbol information for JDK 21 build 27
  • d3d0dbc: 8309756: Occasional crashes with pipewire screen capture on Wayland
  • 9216750: 8308643: Incorrect value of 'used' jvmstat counter
  • 5c70516: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent
  • 81bfd78: 8309632: JDK 21 RDP1 L10n resource files update
  • 9f64a64: 8301379: Verify TLS_ECDH_* cipher suites cannot be negotiated
  • 4a5475c: 8309953: Strengthen and optimize oopDesc age methods
  • 79ff72a: 8308499: Test vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter001/TestDescription.java failed: VMDisconnectedException
  • ... and 4 more: https://git.openjdk.org/jdk/compare/8b4af46be4447a7bc3b58f4054488e8bc50ee111...master

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

Creating backport for repo openjdk/jdk21 on branch master

/backport openjdk/jdk21 master

@openjdk openjdk bot added integrated Pull request has been integrated and removed backport=openjdk/jdk21:master labels Jun 16, 2023
@openjdk openjdk bot closed this Jun 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@lahodaj @biboudis Pushed as commit 32243ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@openjdk[bot] @biboudis the backport was successfully created on the branch biboudis-backport-32243ef4 in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 32243ef4 from the openjdk/jdk repository.

The commit being backported was authored by Aggelos Biboudis on 16 Jun 2023 and was reviewed by Vicente Romero and Jan Lahoda.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git biboudis-backport-32243ef4:biboudis-backport-32243ef4
$ git checkout biboudis-backport-32243ef4
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git biboudis-backport-32243ef4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants