New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8257149: Improve G1 Service thread task scheduling to guarantee task delay #1451
Conversation
👋 Welcome back ayang! A progress list of the required criteria for merging this PR into |
@albertnetymk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this Albert, just a few small comments. If you don't agree just leave them as is.
@albertnetymk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kstefanj, @walulyai) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
All suggestions are applied; thanks for the review. |
/integrate |
@albertnetymk |
/sponsor |
@kstefanj @albertnetymk Pushed as commit 20525d2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Adopt the "at-least" semantics for scheduling delays in G1 service thread scheduling API so that a task is never scheduled earlier than it asked for. IOW,
schedule_task(task, delay_ms)
meanstask
will run after>= delay_ms
has passed.Inspecting the logs (
-Xlog:gc,gc+task*=trace
) and focusing lines containing(Remembered Set Sampling Task) (schedule)
, we can see at what time the sampling task is scheduled.Without
ceil
, sampling task could be scheduled more frequent than intended:With ceil; there's 300ms (
G1ConcRefinementServiceIntervalMillis
) interval btw each scheduling of the sampling task.Tested: tier1 and manually checking the logs.
Progress
Testing
Failed test tasks
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1451/head:pull/1451
$ git checkout pull/1451