Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310259: Pin msys2/setup-msys2 github action to a specific commit #14516

Closed
wants to merge 3 commits into from

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented Jun 16, 2023

Can I please get a review of this change which proposes to address the recent github actions failures?

As noted in https://bugs.openjdk.org/browse/JDK-8310259 the commit in this PR pins the msys2/setup-msys2 to a previous release (that works) and also reverts the change that was done in #14507, for reasons discussed in that PR.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310259: Pin msys2/setup-msys2 github action to a specific commit (Task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14516/head:pull/14516
$ git checkout pull/14516

Update a local copy of the PR:
$ git checkout pull/14516
$ git pull https://git.openjdk.org/jdk.git pull/14516/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14516

View PR using the GUI difftool:
$ git pr show -t 14516

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14516.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2023

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@jaikiran The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Jun 16, 2023
@jaikiran jaikiran changed the title Pin the version of msys2/setup-msys2 github action 8310259: Pin msys2/setup-msys2 github action to a specific commit Jun 17, 2023
@jaikiran jaikiran marked this pull request as ready for review June 17, 2023 02:12
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 17, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2023

Webrevs

Copy link
Member

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the quick fix!

@openjdk
Copy link

openjdk bot commented Jun 17, 2023

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310259: Pin msys2/setup-msys2 github action to a specific commit

Reviewed-by: cstein, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • bcc4d36: 8309511: Regression test ExtraImportSemicolon.java refers to the wrong bug
  • 71baf00: 8309605: StubRoutines are not used by SA
  • 16134f4: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing
  • d6c2ee3: 8310054: ScrollPane insets are incorrect
  • 4eb4f20: 8308808: SunMSCAPI public keys returns internal key array
  • 53abba3: 8309499: javac fails to report compiler.err.no.java.lang with annotation processing enabled
  • cf8d0b0: 8309964: Use directed inheritDoc for javax.lang.model API
  • a45f929: 8310076: Reduce inclusion of bytecodeStream.hpp
  • 21f6d83: 8309471: Limit key characters in static index pages
  • 44a8aa0: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations"
  • ... and 1 more: https://git.openjdk.org/jdk/compare/fb024fde7bffde29dd3ec1ae26d04f4ccd64ad7e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 17, 2023
@jaikiran
Copy link
Member Author

Thank you Christian and Thomas for the reviews.

P.S: The github jobs that have failed in this current PR are unrelated test failures.

@jaikiran
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 17, 2023

Going to push as commit 959a61f.
Since your change was applied there have been 11 commits pushed to the master branch:

  • bcc4d36: 8309511: Regression test ExtraImportSemicolon.java refers to the wrong bug
  • 71baf00: 8309605: StubRoutines are not used by SA
  • 16134f4: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing
  • d6c2ee3: 8310054: ScrollPane insets are incorrect
  • 4eb4f20: 8308808: SunMSCAPI public keys returns internal key array
  • 53abba3: 8309499: javac fails to report compiler.err.no.java.lang with annotation processing enabled
  • cf8d0b0: 8309964: Use directed inheritDoc for javax.lang.model API
  • a45f929: 8310076: Reduce inclusion of bytecodeStream.hpp
  • 21f6d83: 8309471: Limit key characters in static index pages
  • 44a8aa0: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations"
  • ... and 1 more: https://git.openjdk.org/jdk/compare/fb024fde7bffde29dd3ec1ae26d04f4ccd64ad7e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 17, 2023
@openjdk openjdk bot closed this Jun 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 17, 2023
@openjdk
Copy link

openjdk bot commented Jun 17, 2023

@jaikiran Pushed as commit 959a61f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jaikiran jaikiran deleted the pin-msys2-ghaction branch June 17, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants