8309605: StubRoutines are not used by SA#14519
8309605: StubRoutines are not used by SA#14519coleenp wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
|
@coleenp this pull request can not be integrated into git checkout stub-routines
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
/label add serviceability |
|
@coleenp |
|
@coleenp This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
Thanks Chris! |
|
Going to push as commit 71baf00.
Your commit was automatically rebased without conflicts. |
Please remove this trivial fix to remove StubRoutines that the SA doesn't use.
Tested serviceability/sa tests.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14519/head:pull/14519$ git checkout pull/14519Update a local copy of the PR:
$ git checkout pull/14519$ git pull https://git.openjdk.org/jdk.git pull/14519/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14519View PR using the GUI difftool:
$ git pr show -t 14519Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14519.diff
Webrev
Link to Webrev Comment