Skip to content

8309605: StubRoutines are not used by SA#14519

Closed
coleenp wants to merge 2 commits intoopenjdk:masterfrom
coleenp:stub-routines
Closed

8309605: StubRoutines are not used by SA#14519
coleenp wants to merge 2 commits intoopenjdk:masterfrom
coleenp:stub-routines

Conversation

@coleenp
Copy link
Contributor

@coleenp coleenp commented Jun 16, 2023

Please remove this trivial fix to remove StubRoutines that the SA doesn't use.
Tested serviceability/sa tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309605: StubRoutines are not used by SA (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14519/head:pull/14519
$ git checkout pull/14519

Update a local copy of the PR:
$ git checkout pull/14519
$ git pull https://git.openjdk.org/jdk.git pull/14519/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14519

View PR using the GUI difftool:
$ git pr show -t 14519

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14519.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2023

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@coleenp this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout stub-routines
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added merge-conflict Pull request has merge conflict with target branch rfr Pull request is ready for review labels Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@coleenp The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jun 16, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2023

Webrevs

@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Jun 16, 2023
@coleenp
Copy link
Contributor Author

coleenp commented Jun 16, 2023

/label add serviceability

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@coleenp
The serviceability label was successfully added.

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309605: StubRoutines are not used by SA

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 16134f4: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing
  • d6c2ee3: 8310054: ScrollPane insets are incorrect
  • 4eb4f20: 8308808: SunMSCAPI public keys returns internal key array
  • 53abba3: 8309499: javac fails to report compiler.err.no.java.lang with annotation processing enabled
  • cf8d0b0: 8309964: Use directed inheritDoc for javax.lang.model API
  • a45f929: 8310076: Reduce inclusion of bytecodeStream.hpp
  • 21f6d83: 8309471: Limit key characters in static index pages

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 16, 2023
@coleenp
Copy link
Contributor Author

coleenp commented Jun 16, 2023

Thanks Chris!
/integrate

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

Going to push as commit 71baf00.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 16134f4: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing
  • d6c2ee3: 8310054: ScrollPane insets are incorrect
  • 4eb4f20: 8308808: SunMSCAPI public keys returns internal key array
  • 53abba3: 8309499: javac fails to report compiler.err.no.java.lang with annotation processing enabled
  • cf8d0b0: 8309964: Use directed inheritDoc for javax.lang.model API
  • a45f929: 8310076: Reduce inclusion of bytecodeStream.hpp
  • 21f6d83: 8309471: Limit key characters in static index pages

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 16, 2023
@openjdk openjdk bot closed this Jun 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@coleenp Pushed as commit 71baf00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the stub-routines branch June 16, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants