-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8310225: Reduce inclusion of oopMapCache.hpp and generateOopMap.hpp #14525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8310225: Reduce inclusion of oopMapCache.hpp and generateOopMap.hpp #14525
Conversation
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Failing GHAs could be related to JDK-8310183. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
These includes aren't necessary and should be removed:
frame_x86.inline.hpp -> oopMapCache.hpp -> generateOopMap.hpp.
Before:
frame_x86.inline.hpp included 571 times
oopMapCache.hpp included 571 times
generateOopMap.hpp included 571 times
After:
frame_x86.inline.hpp included 571 times
oopMapCache.hpp included 21 times
generateOopMap.hpp included 21 times
(as calculated by https://github.com/iklam/tools/blob/main/headers/whoincludes.tcl)
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14525/head:pull/14525
$ git checkout pull/14525
Update a local copy of the PR:
$ git checkout pull/14525
$ git pull https://git.openjdk.org/jdk.git pull/14525/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14525
View PR using the GUI difftool:
$ git pr show -t 14525
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14525.diff
Webrev
Link to Webrev Comment