Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310225: Reduce inclusion of oopMapCache.hpp and generateOopMap.hpp #14525

Conversation

iklam
Copy link
Member

@iklam iklam commented Jun 16, 2023

These includes aren't necessary and should be removed:

frame_x86.inline.hpp -> oopMapCache.hpp -> generateOopMap.hpp.

Before:
frame_x86.inline.hpp included 571 times
oopMapCache.hpp included 571 times
generateOopMap.hpp included 571 times

After:
frame_x86.inline.hpp included 571 times
oopMapCache.hpp included 21 times
generateOopMap.hpp included 21 times

(as calculated by https://github.com/iklam/tools/blob/main/headers/whoincludes.tcl)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310225: Reduce inclusion of oopMapCache.hpp and generateOopMap.hpp (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14525/head:pull/14525
$ git checkout pull/14525

Update a local copy of the PR:
$ git checkout pull/14525
$ git pull https://git.openjdk.org/jdk.git pull/14525/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14525

View PR using the GUI difftool:
$ git pr show -t 14525

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14525.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2023

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@iklam The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jun 16, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2023

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310225: Reduce inclusion of oopMapCache.hpp and generateOopMap.hpp

Reviewed-by: stuefe, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 16, 2023
@tstuefe
Copy link
Member

tstuefe commented Jun 16, 2023

Failing GHAs could be related to JDK-8310183.

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@iklam
Copy link
Member Author

iklam commented Jun 20, 2023

Thanks @tstuefe and @coleenp for the review!

Merged with mainline and reran tier1 + builds-tier5 tests.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 20, 2023

Going to push as commit 28415ad.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 4c3efb3: 8309034: NoClassDefFoundError when initializing Long$LongCache

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 20, 2023
@openjdk openjdk bot closed this Jun 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 20, 2023
@openjdk
Copy link

openjdk bot commented Jun 20, 2023

@iklam Pushed as commit 28415ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants