-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8309740: Expand timeout windows for tests in JDK-8179502 #14526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/issue 8309740 |
|
👋 Welcome back jnimeh! A progress list of the required criteria for merging this PR into |
|
@jnimeh This issue is referenced in the PR title - it will now be updated. |
|
@jnimeh This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 166 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
MBaesken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/integrate |
|
Going to push as commit 5ca4cdd.
Your commit was automatically rebased without conflicts. |
|
@XueleiFan and/or @MBaesken, would you be able to check out the JDK21 backport (openjdk/jdk21#58)? |
This PR is for tests that were modified/added in JDK-8179502. The timeout windows for those tests were a little too short on some test systems, especially when the system is under heavy load. After a few iterations trying out various longer time windows I have a set that should not run into issues.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14526/head:pull/14526$ git checkout pull/14526Update a local copy of the PR:
$ git checkout pull/14526$ git pull https://git.openjdk.org/jdk.git pull/14526/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14526View PR using the GUI difftool:
$ git pr show -t 14526Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14526.diff
Webrev
Link to Webrev Comment