Skip to content

Conversation

@jnimeh
Copy link
Member

@jnimeh jnimeh commented Jun 16, 2023

This PR is for tests that were modified/added in JDK-8179502. The timeout windows for those tests were a little too short on some test systems, especially when the system is under heavy load. After a few iterations trying out various longer time windows I have a set that should not run into issues.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309740: Expand timeout windows for tests in JDK-8179502 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14526/head:pull/14526
$ git checkout pull/14526

Update a local copy of the PR:
$ git checkout pull/14526
$ git pull https://git.openjdk.org/jdk.git pull/14526/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14526

View PR using the GUI difftool:
$ git pr show -t 14526

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14526.diff

Webrev

Link to Webrev Comment

@jnimeh
Copy link
Member Author

jnimeh commented Jun 16, 2023

/issue 8309740

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2023

👋 Welcome back jnimeh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@jnimeh This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@jnimeh The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jun 16, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@jnimeh This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309740: Expand timeout windows for tests in JDK-8179502

Reviewed-by: xuelei, mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 166 new commits pushed to the master branch:

  • 4bf7816: 8309670: java -help output for --module-path / -p is incomplete
  • d1d2b55: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton
  • d6685f0: 8310510: Remove WordsPerLong
  • 31dcda5: 8295210: IR framework should not whitelist -XX:-UseTLAB
  • 4772893: 8310581: retry_class_loading_during_parsing() is not used
  • 5a82fa3: 8310577: Fix -Wconversion warnings in interpreter and oops
  • 130a9f1: 8292704: sun/security/tools/jarsigner/compatibility/Compatibility.java use wrong key size for EC
  • 0e4fde3: 8310453: Update javadoc of java.lang.Object
  • 230bcb7: 8309685: Fix -Wconversion warnings in assembler and register code
  • 370b8b2: 8310618: Test serviceability/sa/ClhsdbDumpclass.java fails after 8242152: 'StackMapTable:' missing from stdout/stderr
  • ... and 156 more: https://git.openjdk.org/jdk/compare/16c3d53b1bb60b1c1570731041f564bf13b45098...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 16, 2023
Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnimeh
Copy link
Member Author

jnimeh commented Jun 23, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 23, 2023

Going to push as commit 5ca4cdd.
Since your change was applied there have been 167 commits pushed to the master branch:

  • e78fd46: 8310735: Build failure after JDK-8310577 with GCC8
  • 4bf7816: 8309670: java -help output for --module-path / -p is incomplete
  • d1d2b55: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton
  • d6685f0: 8310510: Remove WordsPerLong
  • 31dcda5: 8295210: IR framework should not whitelist -XX:-UseTLAB
  • 4772893: 8310581: retry_class_loading_during_parsing() is not used
  • 5a82fa3: 8310577: Fix -Wconversion warnings in interpreter and oops
  • 130a9f1: 8292704: sun/security/tools/jarsigner/compatibility/Compatibility.java use wrong key size for EC
  • 0e4fde3: 8310453: Update javadoc of java.lang.Object
  • 230bcb7: 8309685: Fix -Wconversion warnings in assembler and register code
  • ... and 157 more: https://git.openjdk.org/jdk/compare/16c3d53b1bb60b1c1570731041f564bf13b45098...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2023
@openjdk openjdk bot closed this Jun 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 23, 2023
@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@jnimeh Pushed as commit 5ca4cdd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jnimeh
Copy link
Member Author

jnimeh commented Jun 23, 2023

@XueleiFan and/or @MBaesken, would you be able to check out the JDK21 backport (openjdk/jdk21#58)?

@jnimeh jnimeh deleted the JDK-8309740 branch December 12, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants