8310266 JFR: Refactor after 'view' command

[egahlin]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8310266: JFR: Refactor after 'view' command (Enhancement - P3)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14532/head:pull/14532
$ git checkout pull/14532

Update a local copy of the PR:
$ git checkout pull/14532
$ git pull https://git.openjdk.org/jdk.git pull/14532/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14532

View PR using the GUI difftool:
$ git pr show -t 14532

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14532.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f8e254d5)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310266: JFR: Refactor after 'view' command

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• b896e3e: 8310146: Removing unused PerfLongVariant::_sampled
• d2a858e: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode()
• 4229baf: 8310015: ZGC: Unbounded asynchronous unmapping can lead to running out of address space
• 266f983: 8308855: ARM32: TestBooleanVector crashes after 8300257
• 6a63bad: 8310191: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java second failure on AIX
• 6473a7d: 8310107: os::trace_page_sizes_for_requested_size should name alignment as requested page size
• 02aaab1: 8310126: C1: Missing receiver null check in Reference::get intrinsic
• 492d25c: 8309601: [JVMCI] AMD64#getLargestStorableKind returns incorrect mask kind
• 959a61f: 8310259: Pin msys2/setup-msys2 github action to a specific commit
• bcc4d36: 8309511: Regression test ExtraImportSemicolon.java refers to the wrong bug
• ... and 13 more: https://git.openjdk.org/jdk/compare/8c9b85a990d955487f9141207cc83d0051defc57...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit e08e94f.
Since your change was applied there have been 25 commits pushed to the master branch:

• f8f8bfb: 8309939: HttpClient should not use Instant.now() as Instant source for deadlines
• 7d4b77a: 8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"
• b896e3e: 8310146: Removing unused PerfLongVariant::_sampled
• d2a858e: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode()
• 4229baf: 8310015: ZGC: Unbounded asynchronous unmapping can lead to running out of address space
• 266f983: 8308855: ARM32: TestBooleanVector crashes after 8300257
• 6a63bad: 8310191: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java second failure on AIX
• 6473a7d: 8310107: os::trace_page_sizes_for_requested_size should name alignment as requested page size
• 02aaab1: 8310126: C1: Missing receiver null check in Reference::get intrinsic
• 492d25c: 8309601: [JVMCI] AMD64#getLargestStorableKind returns incorrect mask kind
• ... and 15 more: https://git.openjdk.org/jdk/compare/8c9b85a990d955487f9141207cc83d0051defc57...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit e08e94f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.