Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310326: Incorrect position of the synthetic unnamed class #14548

Closed
wants to merge 1 commit into from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Jun 19, 2023

Considering code like:

void main() {
}

The method is wrapped in a synthetic class. But, for, this class:

  • SourcePositions.getStartPosition returns 5, while 0 would be better (the reason is the the "name"/"preferred" position from the first member is used, not the starting position for the first member)
  • has (synthetic) empty modifiers with starting position 5, while normally empty modifiers have starting pos -1, e.g.:

This patch proposes to:

  • use the starting position of the first member as the position of the class
  • use -1 as the position for the empty synthetic modifiers of the class

End positions for neither of these is not set, and continues not to be set, and hence getEndPosition returns -1. That is (AFAIK) the common behavior for synthetic trees.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310326: Incorrect position of the synthetic unnamed class (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14548/head:pull/14548
$ git checkout pull/14548

Update a local copy of the PR:
$ git checkout pull/14548
$ git pull https://git.openjdk.org/jdk.git pull/14548/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14548

View PR using the GUI difftool:
$ git pr show -t 14548

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14548.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2023

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@lahodaj The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Jun 19, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 19, 2023

Webrevs

Copy link
Member

@JimLaskey JimLaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310326: Incorrect position of the synthetic unnamed class

Reviewed-by: jlaskey

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 33c6ec9: 8310019: MIPS builds are broken after JDK-8304913
  • e08e94f: 8310266: JFR: Refactor after 'view' command

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 19, 2023
@lahodaj
Copy link
Contributor Author

lahodaj commented Jun 20, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 20, 2023

Going to push as commit 4ca548f.
Since your change was applied there have been 10 commits pushed to the master branch:

  • a059576: 8310187: Improve Generational ZGC jtreg testing
  • 9a68ec8: 8219357: G1: G1GCPhaseTimes::debug_phase uses unnecessary ResourceMark
  • 0878872: 8310020: MacroAssembler::call_VM(_leaf) doesn't consistently check for conflict with C calling convention.
  • 79069c5: 8310314: Misplaced "unnamed classes are a preview feature and are disabled by default" error
  • 96a7db7: 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp
  • b2e86ae: 8304478: Initial nroff manpage generation for JDK 22
  • 7b45c8f: 8241800: Disable IPV6_MULTICAST_ALL to prevent interference from all multicast groups
  • 137a5f7: 8310105: LoongArch64 builds are broken after JDK-8304913
  • 33c6ec9: 8310019: MIPS builds are broken after JDK-8304913
  • e08e94f: 8310266: JFR: Refactor after 'view' command

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 20, 2023
@openjdk openjdk bot closed this Jun 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 20, 2023
@openjdk
Copy link

openjdk bot commented Jun 20, 2023

@lahodaj Pushed as commit 4ca548f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants