Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257164: Share LambdaForms for VH linkers/invokers #1455

Closed
wants to merge 1 commit into from

Conversation

@iwanowww
Copy link

@iwanowww iwanowww commented Nov 26, 2020

Introduce sharing of LambdaForms for VarHandle linkers and invokers.
It reduces the number of LambdaForms needed at runtime.

Testing: tier1-4


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257164: Share LambdaForms for VH linkers/invokers

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1455/head:pull/1455
$ git checkout pull/1455

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 26, 2020

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2020

@iwanowww this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8257164.vh_linker.share
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2020

@iwanowww The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@iwanowww iwanowww force-pushed the 8257164.vh_linker.share branch from a653c58 to aa0279b Nov 26, 2020
@openjdk openjdk bot removed the merge-conflict label Nov 26, 2020
@iwanowww iwanowww changed the title Share LambdaForms for VH linkers/invokers. 8257164: Share LambdaForms for VH linkers/invokers. Nov 26, 2020
@iwanowww iwanowww marked this pull request as ready for review Nov 26, 2020
@openjdk openjdk bot added the rfr label Nov 26, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 26, 2020

Webrevs

cl4es
cl4es approved these changes Nov 27, 2020
Copy link
Member

@cl4es cl4es left a comment

LGTM!

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

@iwanowww
Copy link
Author

@iwanowww iwanowww commented Dec 2, 2020

Thanks for the reviews, Claes, Vladimir, and Paul.

@iwanowww
Copy link
Author

@iwanowww iwanowww commented Dec 2, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2020

@iwanowww This PR has not yet been marked as ready for integration.

@iwanowww iwanowww changed the title 8257164: Share LambdaForms for VH linkers/invokers. 8257164: Share LambdaForms for VH linkers/invokers Dec 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2020

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257164: Share LambdaForms for VH linkers/invokers

Reviewed-by: redestad, kvn, psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 117 new commits pushed to the master branch:

  • 692b273: 8257189: Handle concurrent updates of MH.form better
  • 6704266: 8257565: epsilonBarrierSet.hpp should not include barrierSetAssembler
  • 0b8c780: 8256256: UL should not use heap allocation for output string
  • 2508bc7: 8257140: Crash in JvmtiTagMap::flush_object_free_events()
  • cfb50a9: 8253916: ResourceExhausted/resexhausted001 crashes on Linux-x64
  • 287b829: 8254877: GCLogPrecious::_lock rank constrains what locks you are allowed to have when crashing
  • 1fd0ea7: 8256382: Use try_lock for hs_err EventLog printing
  • bff68f1: 8257533: legacy-jre-image includes jpackage and jlink tools
  • 9a60413: 8248736: [aarch64] runtime/signal/TestSigpoll.java failed "fatal error: not an ldr (literal) instruction."
  • e7ca0c4: 8257224: JDK-8251549 didn't update building.html
  • ... and 107 more: https://git.openjdk.java.net/jdk/compare/26e6cb3eb9a68ded9b0db6bce86afd4523e4c741...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 2, 2020
@iwanowww
Copy link
Author

@iwanowww iwanowww commented Dec 2, 2020

/integrate

@openjdk openjdk bot closed this Dec 2, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2020

@iwanowww Since your change was applied there have been 119 commits pushed to the master branch:

  • 3e89981: 8257623: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java shouldn't use timeout
  • 93b6ab5: 8256818: SSLSocket that is never bound or connected leaks socket resources
  • 692b273: 8257189: Handle concurrent updates of MH.form better
  • 6704266: 8257565: epsilonBarrierSet.hpp should not include barrierSetAssembler
  • 0b8c780: 8256256: UL should not use heap allocation for output string
  • 2508bc7: 8257140: Crash in JvmtiTagMap::flush_object_free_events()
  • cfb50a9: 8253916: ResourceExhausted/resexhausted001 crashes on Linux-x64
  • 287b829: 8254877: GCLogPrecious::_lock rank constrains what locks you are allowed to have when crashing
  • 1fd0ea7: 8256382: Use try_lock for hs_err EventLog printing
  • bff68f1: 8257533: legacy-jre-image includes jpackage and jlink tools
  • ... and 109 more: https://git.openjdk.java.net/jdk/compare/26e6cb3eb9a68ded9b0db6bce86afd4523e4c741...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7104400.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants