8310354: G1: Annotate G1MMUTracker::when_sec with const

[albertnetymk]

Simply adding const to G1MMUTracker APIs.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8310354: G1: Annotate G1MMUTracker::when_sec with const (Enhancement - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14554/head:pull/14554
$ git checkout pull/14554

Update a local copy of the PR:
$ git checkout pull/14554
$ git pull https://git.openjdk.org/jdk.git pull/14554/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14554

View PR using the GUI difftool:
$ git pr show -t 14554

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14554.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (426b6dc9)

[tschatzl]

lgtm

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310354: G1: Annotate G1MMUTracker::when_sec with const

Reviewed-by: tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

• dad7bd9: 8310234: Refactor Locale tests to use JUnit
• 69f3114: 8310676: add note about unnamed module to Elements.getAllModuleElements
• bfcca5e: 8310494: Do not include constantPool.hpp from instanceKlass.hpp
• 0314292: 8310267: Javadoc for Class#isPrimitive() is incorrect regarding Class objects for primitives
• a9c0a0f: 8310628: GcInfoBuilder.c missing JNI Exception checks
• 556831d: 8310460: Remove jdeps -profile option
• d91d0d3: 8310537: Fix -Wconversion warnings in gcUtil.hpp
• 7628da2: 8279254: PKCS9Attribute SigningTime always encoded in UTFTime
• 5ca4cdd: 8309740: Expand timeout windows for tests in JDK-8179502
• e78fd46: 8310735: Build failure after JDK-8310577 with GCC8
• ... and 50 more: https://git.openjdk.org/jdk/compare/087887286d575107c076605e1027b553939c3836...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kimbarrett]

Looks good.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 5271f4d.
Since your change was applied there have been 70 commits pushed to the master branch:

• a420ff4: 6664309: Docking point of a floating toolbar changes after closing
• a96e92c: 8310816: GcInfoBuilder float/double signature mismatch
• c23794f: 8308633: Increase precision of timestamps in g1 log
• 9397094: 8310540: G1: Verification should use raw oop decode functions
• 013367b: 8310868: Thread.interrupt() method's javadoc has an incorrect {@link}
• 9057b35: 8306922: IR verification fails because IR dump is chopped up
• 8242c64: 8310863: Build failure after JDK- 8305341
• 78c3831: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes
• c92b049: 8308780: Fix the Java Integer types on Windows
• 0db63ec: 8310571: Use inline @return tag on java.util.Objects
• ... and 60 more: https://git.openjdk.org/jdk/compare/087887286d575107c076605e1027b553939c3836...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 5271f4d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.