8310332: Fix -Wconversion warnings in MethodData

[coleenp]

Please review this change to narrow parameter and return types to avoid implicit casts, add casts where obvious, add checked_cast<> where not obvious and changed the size of a couple parameters to not cast to the smaller size.
I didn't change TypeProfileWidth and BciProfileWidth because jvmci and SA care about the sizes.
Tested tier1 all Oracle supported platforms, and tier1-4 linux + windows x64.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8310332: Fix -Wconversion warnings in MethodData (Enhancement - P4)

Reviewers

• Andrew Haley (@theRealAph - Reviewer) ⚠️ Review applies to d7ee74d1
• Frederic Parain (@fparain - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14557/head:pull/14557
$ git checkout pull/14557

Update a local copy of the PR:
$ git checkout pull/14557
$ git pull https://git.openjdk.org/jdk.git pull/14557/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14557

View PR using the GUI difftool:
$ git pr show -t 14557

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14557.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (29bf2bd4)
• 01: Full - Incremental (594e617d)
• 00: Full (d7ee74d1)

[theRealAph]

Looks reasonable. Bare narrowing casts, though, give me hives: they're an accident waiting to happen. Having said that, these look safe enough.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310332: Fix -Wconversion warnings in MethodData

Reviewed-by: aph, fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Thank you Andrew. I tried to only use narrowing casts where they're obviously correct because checked_cast<> comes with its own set of problems (and my builds seem to be getting slower). Thanks for reviewing.

[mlbridge]

Mailing list message from Andrew Haley on hotspot-dev:

On 6/20/23 14:23, Coleen Phillimore wrote:

Thank you Andrew. I tried to only use narrowing casts where they're obviously correct because checked_cast<> comes with its own set of problems

Do tell. :-)

(and my builds seem to be getting slower). Thanks for reviewing.

--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

[mlbridge]

Mailing list message from Andrew Haley on hotspot-dev:

On 6/20/23 14:59, Andrew Haley wrote:

On 6/20/23 14:23, Coleen Phillimore wrote:

Thank you Andrew. I tried to only use narrowing casts where they're obviously correct because checked_cast<> comes with its own set of problems

Do tell. :-)

Never mind, I just looked at the palaver with checked_cast in PR 8309685.

--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

[mlbridge]

Mailing list message from coleen.phillimore at oracle.com on hotspot-dev:

On 6/21/23 8:48 AM, Andrew Haley wrote:

On 6/20/23 14:59, Andrew Haley wrote:

On 6/20/23 14:23, Coleen Phillimore wrote:

Thank you Andrew.? I tried to only use narrowing casts where they're
obviously correct because checked_cast<> comes with its own set of
problems

Do tell. :-)

Never mind, I just looked at the palaver with checked_cast in PR 8309685.

palaver? Yes, checked_cast<> was super unhappy with sign extensions,
which the emit_intXX callers do.

[coleenp]

Thank you Andrew and Fred for reviewing.
/integrate

[openjdk]

Going to push as commit fd1163d.
Since your change was applied there have been 3 commits pushed to the master branch:

• 72501cf: 8310379: Relax prerequisites for java.base-jmod target
• 59c6c0e: 8310335: JFR: Modernize collections and switch statements
• 826dcb5: 8264899: C1: -XX:AbortVMOnException does not work if all methods in the call stack are compiled with C1 and there are no exception handlers

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit fd1163d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.