8310405: Linker.Option.firstVariadicArg should specify which index values are valid #14565

JornVernee · 2023-06-20T14:21:26Z

Improve the specification of Linker.Option.firstVariadicArg, by specifying more clearly which index values are valid.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issues

JDK-8310405: Linker.Option.firstVariadicArg should specify which index values are valid (Enhancement - P3)
JDK-8310836: Linker.Option.firstVariadicArg should specify which index values are valid (CSR) (Withdrawn)

Reviewers

Maurizio Cimadamore (@mcimadamore - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14565/head:pull/14565
$ git checkout pull/14565

Update a local copy of the PR:
$ git checkout pull/14565
$ git pull https://git.openjdk.org/jdk.git pull/14565/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14565

View PR using the GUI difftool:
$ git pr show -t 14565

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14565.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-06-20T14:22:33Z

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-06-20T14:24:42Z

@JornVernee The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-06-20T15:39:20Z

Webrevs

src/java.base/share/classes/java/lang/foreign/Linker.java

mcimadamore · 2023-06-23T17:26:59Z

src/java.base/share/classes/java/lang/foreign/Linker.java

         *
-         * @param index the index of the first variadic argument layout in the function descriptor associated
-         *              with a downcall linkage request.
+         * @param index the index indicating the start of the variadic arguments passed to the function described by


My general feeling is that the previous text was better here. We describe in plenty details what this "index" is in the method javadoc. I think I'm more for reverting the changes here.

Co-authored-by: Maurizio Cimadamore <54672762+mcimadamore@users.noreply.github.com>

JornVernee · 2023-06-24T01:15:05Z

I've addressed the review comments. I think we're converging so also went ahead and created the CSR for this.

JornVernee · 2023-06-28T16:11:36Z

/csr unneeded

openjdk · 2023-06-28T16:12:20Z

@JornVernee determined that a CSR request is not needed for this pull request.

openjdk · 2023-06-28T17:27:33Z

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310405: Linker.Option.firstVariadicArg should specify which index values are valid

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 120 new commits pushed to the master branch:

b6c789f: 8309140: ResourceHashtable failed "assert(~(_allocation_t[0] | allocation_mask) == (uintptr_t)this) failed: lost resource object"
9f98136: 6956385: URLConnection.getLastModified() leaks file handles for jar:file and file: URLs
46e4ee1: 8310974: NMT: Arena diffs miss the scale
f17bfee: 8311034: Fix typo in javac man page
2ccdd29: 8299825: Move StdoutLog and StderrLog to LogConfiguration
e3f18af: 8311007: jdk/jfr/tool/TestView.java can't find event
08c51f2: 8310920: Fix -Wconversion warnings in command line flags
c2e9485: 8310921: Fix -Wconversion warnings from GenerateOopMap
ef71c32: 8310110: Shenandoah: Trace page sizes
c3f10e8: 8307625: Redundant receiver null check in LibraryCallKit::generate_method_call
... and 110 more: https://git.openjdk.org/jdk/compare/e1906e76412fa506cf72447dcb9adc896b92ae81...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

JornVernee · 2023-06-28T17:31:07Z

/integrate

openjdk · 2023-06-28T17:32:35Z

Going to push as commit 7fffdb5.
Since your change was applied there have been 120 commits pushed to the master branch:

b6c789f: 8309140: ResourceHashtable failed "assert(~(_allocation_t[0] | allocation_mask) == (uintptr_t)this) failed: lost resource object"
9f98136: 6956385: URLConnection.getLastModified() leaks file handles for jar:file and file: URLs
46e4ee1: 8310974: NMT: Arena diffs miss the scale
f17bfee: 8311034: Fix typo in javac man page
2ccdd29: 8299825: Move StdoutLog and StderrLog to LogConfiguration
e3f18af: 8311007: jdk/jfr/tool/TestView.java can't find event
08c51f2: 8310920: Fix -Wconversion warnings in command line flags
c2e9485: 8310921: Fix -Wconversion warnings from GenerateOopMap
ef71c32: 8310110: Shenandoah: Trace page sizes
c3f10e8: 8307625: Redundant receiver null check in LibraryCallKit::generate_method_call
... and 110 more: https://git.openjdk.org/jdk/compare/e1906e76412fa506cf72447dcb9adc896b92ae81...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-06-28T17:32:48Z

@JornVernee Pushed as commit 7fffdb5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JornVernee · 2023-06-28T17:32:59Z

/backport jdk21

openjdk · 2023-06-28T17:34:30Z

@JornVernee the backport was successfully created on the branch JornVernee-backport-7fffdb5e in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 7fffdb5e from the openjdk/jdk repository.

The commit being backported was authored by Jorn Vernee on 28 Jun 2023 and was reviewed by Maurizio Cimadamore.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git JornVernee-backport-7fffdb5e:JornVernee-backport-7fffdb5e
$ git checkout JornVernee-backport-7fffdb5e
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git JornVernee-backport-7fffdb5e

improve firstVariadicArg doc

24bf486

openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 20, 2023

JornVernee marked this pull request as ready for review June 20, 2023 15:31

openjdk bot added the rfr Pull request is ready for review label Jun 20, 2023

JornVernee marked this pull request as draft June 20, 2023 16:37

openjdk bot removed the rfr Pull request is ready for review label Jun 20, 2023

JornVernee marked this pull request as ready for review June 20, 2023 19:48

openjdk bot added the rfr Pull request is ready for review label Jun 20, 2023

mcimadamore reviewed Jun 20, 2023

View reviewed changes

src/java.base/share/classes/java/lang/foreign/Linker.java Outdated Show resolved Hide resolved

src/java.base/share/classes/java/lang/foreign/Linker.java Outdated Show resolved Hide resolved

src/java.base/share/classes/java/lang/foreign/Linker.java Show resolved Hide resolved

polish doc, review comments

f6a111b

mcimadamore reviewed Jun 23, 2023

View reviewed changes

JornVernee and others added 3 commits June 24, 2023 01:51

Phrasing

263ef78

Co-authored-by: Maurizio Cimadamore <54672762+mcimadamore@users.noreply.github.com>

Update src/java.base/share/classes/java/lang/foreign/Linker.java

352b999

Co-authored-by: Maurizio Cimadamore <54672762+mcimadamore@users.noreply.github.com>

review comments

41c678a

openjdk bot added the csr Pull request needs approved CSR before integration label Jun 23, 2023

openjdk bot removed the csr Pull request needs approved CSR before integration label Jun 28, 2023

mcimadamore approved these changes Jun 28, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 28, 2023

openjdk bot added the integrated Pull request has been integrated label Jun 28, 2023

openjdk bot closed this Jun 28, 2023

openjdk bot removed the ready Pull request is ready to be integrated label Jun 28, 2023

JornVernee deleted the variadicIndexCheck branch June 28, 2023 17:32

openjdk bot removed the rfr Pull request is ready for review label Jun 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8310405: Linker.Option.firstVariadicArg should specify which index values are valid #14565

8310405: Linker.Option.firstVariadicArg should specify which index values are valid #14565

JornVernee commented Jun 20, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jun 20, 2023

openjdk bot commented Jun 20, 2023

mlbridge bot commented Jun 20, 2023 •

edited

Loading

mcimadamore Jun 23, 2023

JornVernee commented Jun 24, 2023

JornVernee commented Jun 28, 2023

openjdk bot commented Jun 28, 2023

openjdk bot commented Jun 28, 2023

JornVernee commented Jun 28, 2023

openjdk bot commented Jun 28, 2023

openjdk bot commented Jun 28, 2023

JornVernee commented Jun 28, 2023

openjdk bot commented Jun 28, 2023

8310405: Linker.Option.firstVariadicArg should specify which index values are valid #14565

8310405: Linker.Option.firstVariadicArg should specify which index values are valid #14565

Conversation

JornVernee commented Jun 20, 2023 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Jun 20, 2023

openjdk bot commented Jun 20, 2023

mlbridge bot commented Jun 20, 2023 • edited Loading

Webrevs

mcimadamore Jun 23, 2023

Choose a reason for hiding this comment

JornVernee commented Jun 24, 2023

JornVernee commented Jun 28, 2023

openjdk bot commented Jun 28, 2023

openjdk bot commented Jun 28, 2023

JornVernee commented Jun 28, 2023

openjdk bot commented Jun 28, 2023

openjdk bot commented Jun 28, 2023

JornVernee commented Jun 28, 2023

openjdk bot commented Jun 28, 2023

JornVernee commented Jun 20, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Jun 20, 2023 •

edited

Loading