Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8310502 : optimization for UUID#toString #14577

Closed
wants to merge 1 commit into from

Conversation

wenshao
Copy link
Contributor

@wenshao wenshao commented Jun 21, 2023

By optimizing the implementation of java.lang.Long#fastUUID, the performance of the java.util.UUID#toString method can be significantly improved.

The following are the test results of JMH:

Benchmark                     Mode  Cnt      Score      Error   Units
UUIDUtilsBenchmark.new       thrpt    5  92676.550 ±  292.213  ops/ms
UUIDUtilsBenchmark.original  thrpt    5  37040.165 ± 1023.532  ops/ms

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8310502

Issue

  • JDK-8310502: Optimization for j.l.Long.fastUUID() (Enhancement - P4) ⚠️ Title mismatch between PR and JBS.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14577/head:pull/14577
$ git checkout pull/14577

Update a local copy of the PR:
$ git checkout pull/14577
$ git pull https://git.openjdk.org/jdk.git pull/14577/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14577

View PR using the GUI difftool:
$ git pr show -t 14577

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14577.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2023

👋 Welcome back wenshao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@wenshao wenshao changed the title optimization for UUID#toString JDK-8310502 : optimization for UUID#toString Jun 21, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 21, 2023
@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@wenshao The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 21, 2023
@wenshao wenshao closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review
1 participant