Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309685: Fix -Wconversion warnings in assembler and register code #14584

Closed
wants to merge 1 commit into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Jun 21, 2023

This is essentially the same as PR #14396 only without the asm/assembler.hpp changes for emit_int8, etc. The casts and type changes here resolve header file -Wconversion warnings but not the 941 in assembler_x86.cpp.
Tested with tier 1-7, and tier1 on Oracle supported platforms.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309685: Fix -Wconversion warnings in assembler and register code (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14584/head:pull/14584
$ git checkout pull/14584

Update a local copy of the PR:
$ git checkout pull/14584
$ git pull https://git.openjdk.org/jdk.git pull/14584/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14584

View PR using the GUI difftool:
$ git pr show -t 14584

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14584.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2023

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 21, 2023
@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@coleenp The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jun 21, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2023

Webrevs

emit_int8((uint8_t)0x2e); // cs:
emit_int8((uint8_t)0x64); // fs:
emit_int8((uint8_t)0x65); // gs:
emit_int8((uint8_t)0x90);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there us a better way to do this with a template emit_int8() function, but maybe not now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed these casts as an alternative to the emit_int8 templates, so left them in this patch because they're more correct than what was there. The emit_intXX functions need special treatment that I don't know how to fix right now.

Copy link
Contributor

@theRealAph theRealAph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309685: Fix -Wconversion warnings in assembler and register code

Reviewed-by: aph, fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

  • 370b8b2: 8310618: Test serviceability/sa/ClhsdbDumpclass.java fails after 8242152: 'StackMapTable:' missing from stdout/stderr
  • 5a30fb6: 8310591: Missing @since tags in java.lang.foreign
  • 8976ebf: 8310561: JFR: Unify decodeDescriptors(String, String)
  • 7da3f19: 8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns
  • 8e04702: 8242152: SA does not include StackMapTables when dumping .class files
  • 3bc475e: 8309909: remove test nsk.jvmti test objmonusage006 from ProblemList-Virtual.txt
  • 3661cde: 8309853: StructuredTaskScope.join description improvements
  • ac44ef1: 8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all
  • 3be50da: 8310512: Cleanup indentation in jfc files
  • f286e5a: 8310575: no @since for StandardDoclet
  • ... and 21 more: https://git.openjdk.org/jdk/compare/11201067a8d429fcb03f90830abec1842efae5fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 21, 2023
@coleenp
Copy link
Contributor Author

coleenp commented Jun 21, 2023

Thanks for reviewing and your attention @theRealAph.

@coleenp
Copy link
Contributor Author

coleenp commented Jun 22, 2023

Thanks for reviewing @fparain
/integrate

@openjdk
Copy link

openjdk bot commented Jun 22, 2023

Going to push as commit 230bcb7.
Since your change was applied there have been 31 commits pushed to the master branch:

  • 370b8b2: 8310618: Test serviceability/sa/ClhsdbDumpclass.java fails after 8242152: 'StackMapTable:' missing from stdout/stderr
  • 5a30fb6: 8310591: Missing @since tags in java.lang.foreign
  • 8976ebf: 8310561: JFR: Unify decodeDescriptors(String, String)
  • 7da3f19: 8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns
  • 8e04702: 8242152: SA does not include StackMapTables when dumping .class files
  • 3bc475e: 8309909: remove test nsk.jvmti test objmonusage006 from ProblemList-Virtual.txt
  • 3661cde: 8309853: StructuredTaskScope.join description improvements
  • ac44ef1: 8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all
  • 3be50da: 8310512: Cleanup indentation in jfc files
  • f286e5a: 8310575: no @since for StandardDoclet
  • ... and 21 more: https://git.openjdk.org/jdk/compare/11201067a8d429fcb03f90830abec1842efae5fd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 22, 2023
@openjdk openjdk bot closed this Jun 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 22, 2023
@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@coleenp Pushed as commit 230bcb7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the asm-conversion branch June 22, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants