Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257181: s390x builds are very noisy with gc-sections messages #1459

Closed

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Nov 26, 2020

Sample build log sizes:

PPC64 fastdebug, 200 kilobytes:
https://builds.shipilev.net/openjdk-jdk/build-logs/build-linux-ppc64le-fastdebug.log

S390X fastdebug, 20 megabytes!
https://builds.shipilev.net/openjdk-jdk/build-logs/build-linux-s390x-server-fastdebug.log

S390X slowdebug, 200 megabytes!
https://builds.shipilev.net/openjdk-jdk/build-logs/build-linux-s390x-server-slowdebug.log

JDK-8234525 enabled gc-sections. We can and should disable print-gc-sections to get sane build logs back.

Additional testing:

  • Linux s390x fastdebug cross-compilation

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux additional Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (8/8 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) (1/9 failed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-8257181: s390x builds are very noisy with gc-sections messages

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1459/head:pull/1459
$ git checkout pull/1459

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 26, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 26, 2020
@openjdk
Copy link

openjdk bot commented Nov 26, 2020

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Nov 26, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 26, 2020

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

I agree. This is far too much for the regular build.
If anybody wants to check unused functions, it should better be turned on locally.

@openjdk
Copy link

openjdk bot commented Nov 26, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257181: s390x builds are very noisy with gc-sections messages

Reviewed-by: mdoerr, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 6e00622: 8256488: [aarch64] Use ldpq/stpq instead of ld4/st4 for small copies in StubGenerator::copy_memory
  • a93841a: 8255277: randomDelay in DrainDeadlockT and LoggingDeadlock do not randomly delay
  • 2d30a10: 8257069: C2: Clarify and sanity test RegMask/RegMaskIterator
  • 0a5de50: 8257151: ZGC: Simplify ZVerify
  • bf66d73: 8257073: ZGC: Try forward object before retaining page

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 26, 2020
Copy link
Contributor

@RealLucy RealLucy left a comment

This "noise generator" looks like a leftover from way back development times. Thanks for tracking this down.

@shipilev
Copy link
Contributor Author

shipilev commented Nov 26, 2020

Thanks. Trivial, right? (So I can push now?)

@RealLucy
Copy link
Contributor

RealLucy commented Nov 26, 2020

@shipilev
Copy link
Contributor Author

shipilev commented Nov 27, 2020

Thanks!

/integrate

@openjdk openjdk bot closed this Nov 27, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 27, 2020
@openjdk
Copy link

openjdk bot commented Nov 27, 2020

@shipilev Since your change was applied there have been 9 commits pushed to the master branch:

  • 9a468d8: 8256757: Incorrect MachCallRuntimeNode::ret_addr_offset() for CallLeafNoFP on x86_32
  • 2215e5a: 8255351: Add detection for Graviton 2 CPUs
  • 62d72de: 8220730: sun.security.provider.SecureRandom default constructor has wrong documentation
  • 4e43b28: 8256359: AArch64: runtime/ReservedStack/ReservedStackTestCompiler.java fails
  • 6e00622: 8256488: [aarch64] Use ldpq/stpq instead of ld4/st4 for small copies in StubGenerator::copy_memory
  • a93841a: 8255277: randomDelay in DrainDeadlockT and LoggingDeadlock do not randomly delay
  • 2d30a10: 8257069: C2: Clarify and sanity test RegMask/RegMaskIterator
  • 0a5de50: 8257151: ZGC: Simplify ZVerify
  • bf66d73: 8257073: ZGC: Try forward object before retaining page

Your commit was automatically rebased without conflicts.

Pushed as commit a3eec39.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8257181-s390x-build-noise branch Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
3 participants