Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308633: Increase precision of timestamps in g1 log #14594

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jun 21, 2023

Hi all,

please review this improvement adding a digit to log timestamp to improve output. On modern machines, for some pauses, this can lead to sub-phase timings not adding up, and during development, extra work to evaluate different options.
Also that rounding error starts to matter for e.g. pauses < a few ms.

I am aware that there is a duplication of the timestamp format in the files, and this change did not improve that as this would be a different issue. Not sure where to put such a global constant though, any suggestions?

Testing: gha, looking at log files

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308633: Increase precision of timestamps in g1 log (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14594/head:pull/14594
$ git checkout pull/14594

Update a local copy of the PR:
$ git checkout pull/14594
$ git pull https://git.openjdk.org/jdk.git pull/14594/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14594

View PR using the GUI difftool:
$ git pr show -t 14594

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14594.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2023

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8308633 8308633: Increase precision of timestamps in g1 log Jun 21, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 21, 2023
@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jun 21, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308633: Increase precision of timestamps in g1 log

Reviewed-by: ayang, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 93 new commits pushed to the master branch:

  • dad7bd9: 8310234: Refactor Locale tests to use JUnit
  • 69f3114: 8310676: add note about unnamed module to Elements.getAllModuleElements
  • bfcca5e: 8310494: Do not include constantPool.hpp from instanceKlass.hpp
  • 0314292: 8310267: Javadoc for Class#isPrimitive() is incorrect regarding Class objects for primitives
  • a9c0a0f: 8310628: GcInfoBuilder.c missing JNI Exception checks
  • 556831d: 8310460: Remove jdeps -profile option
  • d91d0d3: 8310537: Fix -Wconversion warnings in gcUtil.hpp
  • 7628da2: 8279254: PKCS9Attribute SigningTime always encoded in UTFTime
  • 5ca4cdd: 8309740: Expand timeout windows for tests in JDK-8179502
  • e78fd46: 8310735: Build failure after JDK-8310577 with GCC8
  • ... and 83 more: https://git.openjdk.org/jdk/compare/8c9b85a990d955487f9141207cc83d0051defc57...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 22, 2023
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tschatzl
Copy link
Contributor Author

Thanks @albertnetymk @kimbarrett for your reviews
/integrate

@openjdk
Copy link

openjdk bot commented Jun 26, 2023

Going to push as commit c23794f.
Since your change was applied there have been 100 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 26, 2023
@openjdk openjdk bot closed this Jun 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 26, 2023
@openjdk
Copy link

openjdk bot commented Jun 26, 2023

@tschatzl Pushed as commit c23794f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8308633-g1-log-timestamps branch October 24, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants